Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(89)

Issue 1856623002: convert //rlz to std::unique_ptr (Closed)

Created:
4 years, 8 months ago by Mostyn Bramley-Moore
Modified:
4 years, 8 months ago
Reviewers:
Nico
CC:
chromium-reviews, alito+watch_chromium.org, gab+watch_chromium.org, robertshield+watch_chromium.org, oshima+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

convert //rlz to std::unique_ptr BUG=554298 Committed: https://crrev.com/03c6cc125a0f63fcf549db5caa525ad5941fffd8 Cr-Commit-Position: refs/heads/master@{#384837}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -16 lines) Patch
M rlz/chromeos/lib/rlz_value_store_chromeos.h View 2 chunks +3 lines, -1 line 0 comments Download
M rlz/chromeos/lib/rlz_value_store_chromeos.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M rlz/lib/financial_ping.cc View 4 chunks +5 lines, -4 lines 0 comments Download
M rlz/lib/rlz_lib_test.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M rlz/lib/rlz_value_store.h View 2 chunks +2 lines, -2 lines 0 comments Download
M rlz/win/lib/machine_deal.cc View 1 chunk +0 lines, -1 line 0 comments Download
M rlz/win/lib/machine_id_win.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M rlz/win/lib/process_info.cc View 1 chunk +0 lines, -1 line 0 comments Download
M rlz/win/lib/rlz_lib_win.cc View 2 chunks +3 lines, -1 line 0 comments Download

Messages

Total messages: 20 (9 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1856623002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1856623002/1
4 years, 8 months ago (2016-04-03 19:17:22 UTC) #2
Mostyn Bramley-Moore
@Glenn: please take a look.
4 years, 8 months ago (2016-04-03 20:00:13 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 8 months ago (2016-04-03 20:05:27 UTC) #6
gwilson
On 2016/04/03 20:05:27, commit-bot: I haz the power wrote: > Dry run: This issue passed ...
4 years, 8 months ago (2016-04-03 20:15:45 UTC) #7
Mostyn Bramley-Moore
On 2016/04/03 20:15:45, gwilson wrote: > I'm probably not the best one to review this ...
4 years, 8 months ago (2016-04-03 20:23:29 UTC) #10
Nico
Lgtm If gwilson doesn't want to review here and is still in the owners file, ...
4 years, 8 months ago (2016-04-03 21:16:03 UTC) #12
Mostyn Bramley-Moore
On 2016/04/03 21:16:03, Nico wrote: > Lgtm Thanks. > If gwilson doesn't want to review ...
4 years, 8 months ago (2016-04-03 22:04:04 UTC) #13
Mostyn Bramley-Moore
On 2016/04/03 21:16:03, Nico wrote: > Lgtm Thanks. > If gwilson doesn't want to review ...
4 years, 8 months ago (2016-04-03 22:04:05 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1856623002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1856623002/1
4 years, 8 months ago (2016-04-03 22:04:19 UTC) #16
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-03 22:09:37 UTC) #18
commit-bot: I haz the power
4 years, 8 months ago (2016-04-03 22:11:09 UTC) #20
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/03c6cc125a0f63fcf549db5caa525ad5941fffd8
Cr-Commit-Position: refs/heads/master@{#384837}

Powered by Google App Engine
This is Rietveld 408576698