Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(333)

Issue 1856603002: Introduce IsGraphemeBreak function. (Closed)

Created:
4 years, 8 months ago by Seigo Nonaka
Modified:
4 years, 8 months ago
Reviewers:
tkent, yosin_UTC9
CC:
blink-reviews, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Introduce IsGraphemeBreak function. Followings are differences from the previous grapheme breaker: - Follows latest(including proposed) grapheme breaker spec: Unicode Standard Annex #29 http://www.unicode.org/reports/tr29 - Removed Tamil exception rule from Indic syllable composition. Introduced by https://bugs.webkit.org/show_bug.cgi?id=15790 Neither bug nor change description doesn't mention about Tamil exception but latest Unicode standards doesn't have exception. - Revive Rule GB9b rule: don't break after Prepend property. Introduced by https://bugs.webkit.org/show_bug.cgi?id=24342 It is safe to revive this rule since Thai characters no longer have Prepend property since Unicode 6.1. Note that there are no character having Prepend property until Unicode 9.0 after Unicode 6.1 IsGraphemeBreak function is compiled and tested but not used on production. This function is used by subsequent CLs. BUG=594923 Committed: https://crrev.com/376ec7f5a84c0e2f03f813310450c375991f8591 Cr-Commit-Position: refs/heads/master@{#384852}

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+330 lines, -0 lines) Patch
M third_party/WebKit/Source/core/core.gypi View 2 chunks +3 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/core/editing/state_machines/StateMachineUtil.h View 1 chunk +22 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/core/editing/state_machines/StateMachineUtil.cpp View 1 chunk +140 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/core/editing/state_machines/StateMachineUtilTest.cpp View 1 chunk +165 lines, -0 lines 0 comments Download

Messages

Total messages: 17 (8 generated)
Seigo Nonaka
Hi Yoshi-san, I'd like to split https://codereview.chromium.org/1833413002/ into four. This is the first patch. Could ...
4 years, 8 months ago (2016-04-03 19:18:40 UTC) #4
yosin_UTC9
lgtm +tkent@ for core OWNERS review
4 years, 8 months ago (2016-04-04 03:49:16 UTC) #6
tkent
> IsGraphemeBreak function is compiled and tested but not used on > production. So, what's ...
4 years, 8 months ago (2016-04-04 04:01:10 UTC) #7
Seigo Nonaka
I'm sorry for providing few background. This is a part of large CLs: https://codereview.chromium.org/1833413002/ I'd ...
4 years, 8 months ago (2016-04-04 04:14:33 UTC) #9
tkent
lgtm On 2016/04/04 at 04:14:33, nona wrote: > If submitting temporary unused classes doesn't make ...
4 years, 8 months ago (2016-04-04 04:24:19 UTC) #10
Seigo Nonaka
On 2016/04/04 04:24:19, tkent wrote: > lgtm > > On 2016/04/04 at 04:14:33, nona wrote: ...
4 years, 8 months ago (2016-04-04 05:03:22 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1856603002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1856603002/20001
4 years, 8 months ago (2016-04-04 05:03:37 UTC) #13
commit-bot: I haz the power
Committed patchset #1 (id:20001)
4 years, 8 months ago (2016-04-04 06:02:44 UTC) #15
commit-bot: I haz the power
4 years, 8 months ago (2016-04-04 06:05:39 UTC) #17
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/376ec7f5a84c0e2f03f813310450c375991f8591
Cr-Commit-Position: refs/heads/master@{#384852}

Powered by Google App Engine
This is Rietveld 408576698