Optimize loop condition for SincResampler.

media/media.gyp

Index: media/media.gyp
diff --git a/media/media.gyp b/media/media.gyp
index 88b28dcefbccdbebbb85fa7f5b321095660ed21e..d8f7f9687ddee45d768646a82654f28fe78e1b97 100644
--- a/media/media.gyp
+++ b/media/media.gyp
@@ -452,7 +452,7 @@
         ],
       },
       'conditions': [
-        ['arm_neon==1', {
+        ['target_arch=="arm" and arm_version>=7 and arm_neon==1', {

[Ami GONE FROM CHROMIUM, 2013/07/10 21:18:00]

FWIW, this will break when targeting ios (device, not simulator) in a ninja
build, when target_arch=="armv7".  I don't know what the right thing to do here
is, but that doesn't need to block this CL.

[DaleCurtis, 2013/07/10 23:01:34]

Ugh. How does that even work at all? No code outside of common.gypi (that I can
find in code search) checks for a target_arch of armv7. Is none of the existing
code under target_arch=arm used in iOS?

[Ami GONE FROM CHROMIUM, 2013/07/10 23:04:41]

Very little is in fact built into bling...

[DaleCurtis, 2013/07/11 21:04:34]

I've dropped these changes from the latest patch set.

           'defines': [
             'USE_NEON'
           ],
@@ -985,7 +985,7 @@
         'webm/webm_webvtt_parser_unittest.cc',
       ],
       'conditions': [
-        ['arm_neon==1', {
+        ['target_arch=="arm" and arm_version>=7 and arm_neon==1', {

[Ami GONE FROM CHROMIUM, 2013/07/09 23:20:08]

Why not instead change build/common.gypi to not default arm_neon on on non-arm
platforms?

[DaleCurtis, 2013/07/10 21:06:31]

Hmm, that's non-trivial since target_arch isn't defined at the point arm_neon is
set (and consumed by other common.gypi pieces). I also worry that it'll have
negative effects on iOS which specifies a target_arch of x86 while really
targeting arm:

https://code.google.com/p/chromium/issues/detail?id=172682

The check I have hear is what is used elsewhere in the codebase (see skia.gyp).

           'defines': [
             'USE_NEON'
           ],