Optimize loop condition for SincResampler.

media/media.gyp

 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 {
   'variables': {
     'chromium_code': 1,
     # Override to dynamically link the cras (ChromeOS audio) library.
     'use_cras%': 0,
     # Option e.g. for Linux distributions to link pulseaudio directly
@@ skipping 434 matching lines @@
         'webm/webm_video_client.h',
         'webm/webm_webvtt_parser.cc',
         'webm/webm_webvtt_parser.h'
       ],
       'direct_dependent_settings': {
         'include_dirs': [
           '..',
         ],
       },
       'conditions': [
-        ['arm_neon==1', {
+        ['target_arch=="arm" and arm_version>=7 and arm_neon==1', {

[Ami GONE FROM CHROMIUM, 2013/07/10 21:18:00]

FWIW, this will break when targeting ios (device, not simulator) in a ninja
build, when target_arch=="armv7".  I don't know what the right thing to do here
is, but that doesn't need to block this CL.

[DaleCurtis, 2013/07/10 23:01:34]

Ugh. How does that even work at all? No code outside of common.gypi (that I can
find in code search) checks for a target_arch of armv7. Is none of the existing
code under target_arch=arm used in iOS?

[Ami GONE FROM CHROMIUM, 2013/07/10 23:04:41]

Very little is in fact built into bling...

[DaleCurtis, 2013/07/11 21:04:34]

I've dropped these changes from the latest patch set.

           'defines': [
             'USE_NEON'
           ],
         }],
         ['OS!="ios"', {
           'dependencies': [
             '../base/third_party/dynamic_annotations/dynamic_annotations.gyp:dynamic_annotations',
             '../gpu/gpu.gyp:command_buffer_common',
             'shared_memory_support',
           ],
@@ skipping 512 matching lines @@
         'webm/cluster_builder.h',
         'webm/tracks_builder.cc',
         'webm/tracks_builder.h',
         'webm/webm_cluster_parser_unittest.cc',
         'webm/webm_content_encodings_client_unittest.cc',
         'webm/webm_parser_unittest.cc',
         'webm/webm_tracks_parser_unittest.cc',
         'webm/webm_webvtt_parser_unittest.cc',
       ],
       'conditions': [
-        ['arm_neon==1', {
+        ['target_arch=="arm" and arm_version>=7 and arm_neon==1', {

[Ami GONE FROM CHROMIUM, 2013/07/09 23:20:08]

Why not instead change build/common.gypi to not default arm_neon on on non-arm
platforms?

[DaleCurtis, 2013/07/10 21:06:31]

Hmm, that's non-trivial since target_arch isn't defined at the point arm_neon is
set (and consumed by other common.gypi pieces). I also worry that it'll have
negative effects on iOS which specifies a target_arch of x86 while really
targeting arm:

https://code.google.com/p/chromium/issues/detail?id=172682

The check I have hear is what is used elsewhere in the codebase (see skia.gyp).

           'defines': [
             'USE_NEON'
           ],
         }],
         ['OS!="ios"', {
           'dependencies': [
             '../gpu/gpu.gyp:command_buffer_common',
             'shared_memory_support',
           ],
         }],
@@ skipping 629 matching lines @@
           'sources': [
             'tools/media_bench/media_bench.cc',
           ],
           # TODO(jschuh): crbug.com/167187 fix size_t to int truncations.
           'msvs_disabled_warnings': [ 4267, ],
         },
       ],
     }],
   ],
 }