Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(800)

Issue 1856553002: [Media Router WebUI] Move dialog load focusing to container. (Closed)

Created:
4 years, 8 months ago by apacible
Modified:
4 years, 8 months ago
Reviewers:
mark a. foltz
CC:
arv+watch_chromium.org, chromium-reviews, media-router+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Media Router WebUI] Move dialog load focusing to container. This ensures the first run flow is taken into account, since those elements may appear before the header elements in the DOM tree. Manually tested on Linux/Mac. BUG=598278 Committed: https://crrev.com/f6a6cb0dd0ffda3cdfe66c5676072cfdea25794f Cr-Commit-Position: refs/heads/master@{#385213}

Patch Set 1 : #

Total comments: 6

Patch Set 2 : Changes per mfoltz@'s comments. #

Messages

Total messages: 18 (12 generated)
apacible
PTAL, thanks!
4 years, 8 months ago (2016-04-04 16:09:13 UTC) #8
mark a. foltz
LGTM with some clarifications requested. The patch description might go into a bit more detail ...
4 years, 8 months ago (2016-04-04 20:40:37 UTC) #9
apacible
Also manually tested on Mac and Linux. https://codereview.chromium.org/1856553002/diff/80001/chrome/browser/resources/media_router/elements/media_router_container/media_router_container.js File chrome/browser/resources/media_router/elements/media_router_container/media_router_container.js (right): https://codereview.chromium.org/1856553002/diff/80001/chrome/browser/resources/media_router/elements/media_router_container/media_router_container.js#newcode1351 chrome/browser/resources/media_router/elements/media_router_container/media_router_container.js:1351: // If ...
4 years, 8 months ago (2016-04-05 17:30:33 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1856553002/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1856553002/100001
4 years, 8 months ago (2016-04-05 17:30:57 UTC) #14
commit-bot: I haz the power
Committed patchset #2 (id:100001)
4 years, 8 months ago (2016-04-05 17:37:55 UTC) #16
commit-bot: I haz the power
4 years, 8 months ago (2016-04-05 17:39:02 UTC) #18
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/f6a6cb0dd0ffda3cdfe66c5676072cfdea25794f
Cr-Commit-Position: refs/heads/master@{#385213}

Powered by Google App Engine
This is Rietveld 408576698