Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(313)

Issue 185653012: rAc - fix off-by-small-number error in grid layout (Closed)

Created:
6 years, 9 months ago by Evan Stade
Modified:
6 years, 9 months ago
Reviewers:
sky
CC:
chromium-reviews, tfarina
Visibility:
Public.

Description

rAc - fix off-by-small-number error in grid layout This was visible in a couple of rows where the right side of the last input column didn't align with the right side of the (sole) input on the previous/next lines. BUG=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=255299

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -1 line) Patch
M ui/views/layout/grid_layout.cc View 1 chunk +2 lines, -1 line 0 comments Download
M ui/views/layout/grid_layout_unittest.cc View 1 chunk +27 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
Evan Stade
6 years, 9 months ago (2014-03-04 02:24:46 UTC) #1
sky
LGTM
6 years, 9 months ago (2014-03-04 05:19:21 UTC) #2
Evan Stade
The CQ bit was checked by estade@chromium.org
6 years, 9 months ago (2014-03-04 23:04:46 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/estade@chromium.org/185653012/1
6 years, 9 months ago (2014-03-04 23:11:25 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-05 00:19:59 UTC) #5
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) app_list_unittests, ash_unittests, aura_unittests, cacheinvalidation_unittests, cc_unittests, check_deps, ...
6 years, 9 months ago (2014-03-05 00:20:00 UTC) #6
Evan Stade
The CQ bit was checked by estade@chromium.org
6 years, 9 months ago (2014-03-05 23:15:16 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/estade@chromium.org/185653012/1
6 years, 9 months ago (2014-03-05 23:16:52 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/estade@chromium.org/185653012/1
6 years, 9 months ago (2014-03-06 00:09:20 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/estade@chromium.org/185653012/1
6 years, 9 months ago (2014-03-06 02:51:25 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/estade@chromium.org/185653012/1
6 years, 9 months ago (2014-03-06 03:16:05 UTC) #11
commit-bot: I haz the power
6 years, 9 months ago (2014-03-06 10:39:35 UTC) #12
Message was sent while issue was closed.
Change committed as 255299

Powered by Google App Engine
This is Rietveld 408576698