| Index: src/x64/full-codegen-x64.cc
|
| diff --git a/src/x64/full-codegen-x64.cc b/src/x64/full-codegen-x64.cc
|
| index 50610897d6f17d4591e183c3a3494395969e45bd..badf18ed678d2ad0274bad137d4f60e52c142e8e 100644
|
| --- a/src/x64/full-codegen-x64.cc
|
| +++ b/src/x64/full-codegen-x64.cc
|
| @@ -118,6 +118,9 @@ void FullCodeGenerator::Generate() {
|
| CompilationInfo* info = info_;
|
| handler_table_ =
|
| isolate()->factory()->NewFixedArray(function()->handler_count(), TENURED);
|
| +
|
| + InitializeFeedbackVector();
|
| +
|
| profiling_counter_ = isolate()->factory()->NewCell(
|
| Handle<Smi>(Smi::FromInt(FLAG_interrupt_budget), isolate()));
|
| SetFunctionPosition(function());
|
| @@ -182,20 +185,22 @@ void FullCodeGenerator::Generate() {
|
| if (heap_slots > 0) {
|
| Comment cmnt(masm_, "[ Allocate context");
|
| // Argument to NewContext is the function, which is still in rdi.
|
| - __ push(rdi);
|
| if (FLAG_harmony_scoping && info->scope()->is_global_scope()) {
|
| + __ push(rdi);
|
| __ Push(info->scope()->GetScopeInfo());
|
| __ CallRuntime(Runtime::kNewGlobalContext, 2);
|
| } else if (heap_slots <= FastNewContextStub::kMaximumSlots) {
|
| FastNewContextStub stub(heap_slots);
|
| __ CallStub(&stub);
|
| } else {
|
| + __ push(rdi);
|
| __ CallRuntime(Runtime::kNewFunctionContext, 1);
|
| }
|
| function_in_register = false;
|
| - // Context is returned in both rax and rsi. It replaces the context
|
| - // passed to us. It's saved in the stack and kept live in rsi.
|
| - __ movp(Operand(rbp, StandardFrameConstants::kContextOffset), rsi);
|
| + // Context is returned in rax. It replaces the context passed to us.
|
| + // It's saved in the stack and kept live in rsi.
|
| + __ movp(rsi, rax);
|
| + __ movp(Operand(rbp, StandardFrameConstants::kContextOffset), rax);
|
|
|
| // Copy any necessary parameters into the context.
|
| int num_parameters = info->scope()->num_parameters();
|
| @@ -636,7 +641,7 @@ void FullCodeGenerator::DoTest(Expression* condition,
|
| Label* if_false,
|
| Label* fall_through) {
|
| Handle<Code> ic = ToBooleanStub::GetUninitialized(isolate());
|
| - CallIC(ic, NOT_CONTEXTUAL, condition->test_id());
|
| + CallIC(ic, condition->test_id());
|
| __ testq(result_register(), result_register());
|
| // The stub returns nonzero for true.
|
| Split(not_zero, if_true, if_false, fall_through);
|
| @@ -989,7 +994,7 @@ void FullCodeGenerator::VisitSwitchStatement(SwitchStatement* stmt) {
|
| // Record position before stub call for type feedback.
|
| SetSourcePosition(clause->position());
|
| Handle<Code> ic = CompareIC::GetUninitialized(isolate(), Token::EQ_STRICT);
|
| - CallIC(ic, NOT_CONTEXTUAL, clause->CompareId());
|
| + CallIC(ic, clause->CompareId());
|
| patch_site.EmitPatchInfo();
|
|
|
| Label skip;
|
| @@ -1033,6 +1038,7 @@ void FullCodeGenerator::VisitSwitchStatement(SwitchStatement* stmt) {
|
|
|
| void FullCodeGenerator::VisitForInStatement(ForInStatement* stmt) {
|
| Comment cmnt(masm_, "[ ForInStatement");
|
| + int slot = stmt->ForInFeedbackSlot();
|
| SetStatementPosition(stmt);
|
|
|
| Label loop, exit;
|
| @@ -1121,14 +1127,15 @@ void FullCodeGenerator::VisitForInStatement(ForInStatement* stmt) {
|
| Label non_proxy;
|
| __ bind(&fixed_array);
|
|
|
| - Handle<Cell> cell = isolate()->factory()->NewCell(
|
| - Handle<Object>(Smi::FromInt(TypeFeedbackCells::kForInFastCaseMarker),
|
| - isolate()));
|
| - RecordTypeFeedbackCell(stmt->ForInFeedbackId(), cell);
|
| - __ Move(rbx, cell);
|
| - __ Move(FieldOperand(rbx, Cell::kValueOffset),
|
| - Smi::FromInt(TypeFeedbackCells::kForInSlowCaseMarker));
|
| + Handle<Object> feedback = Handle<Object>(
|
| + Smi::FromInt(TypeFeedbackInfo::kForInFastCaseMarker),
|
| + isolate());
|
| + StoreFeedbackVectorSlot(slot, feedback);
|
|
|
| + // No need for a write barrier, we are storing a Smi in the feedback vector.
|
| + __ Move(rbx, FeedbackVector());
|
| + __ Move(FieldOperand(rbx, FixedArray::OffsetOfElementAt(slot)),
|
| + Smi::FromInt(TypeFeedbackInfo::kForInSlowCaseMarker));
|
| __ Move(rbx, Smi::FromInt(1)); // Smi indicates slow check
|
| __ movp(rcx, Operand(rsp, 0 * kPointerSize)); // Get enumerated object
|
| STATIC_ASSERT(FIRST_JS_PROXY_TYPE == FIRST_SPEC_OBJECT_TYPE);
|
| @@ -1437,7 +1444,7 @@ void FullCodeGenerator::EmitVariableLoad(VariableProxy* proxy) {
|
| // variables.
|
| switch (var->location()) {
|
| case Variable::UNALLOCATED: {
|
| - Comment cmnt(masm_, "Global variable");
|
| + Comment cmnt(masm_, "[ Global variable");
|
| // Use inline caching. Variable name is passed in rcx and the global
|
| // object on the stack.
|
| __ Move(rcx, var->name());
|
| @@ -1450,7 +1457,8 @@ void FullCodeGenerator::EmitVariableLoad(VariableProxy* proxy) {
|
| case Variable::PARAMETER:
|
| case Variable::LOCAL:
|
| case Variable::CONTEXT: {
|
| - Comment cmnt(masm_, var->IsContextSlot() ? "Context slot" : "Stack slot");
|
| + Comment cmnt(masm_, var->IsContextSlot() ? "[ Context slot"
|
| + : "[ Stack slot");
|
| if (var->binding_needs_init()) {
|
| // var->scope() may be NULL when the proxy is located in eval code and
|
| // refers to a potential outside binding. Currently those bindings are
|
| @@ -1512,12 +1520,12 @@ void FullCodeGenerator::EmitVariableLoad(VariableProxy* proxy) {
|
| }
|
|
|
| case Variable::LOOKUP: {
|
| + Comment cmnt(masm_, "[ Lookup slot");
|
| Label done, slow;
|
| // Generate code for loading from variables potentially shadowed
|
| // by eval-introduced variables.
|
| EmitDynamicLookupFastCase(var, NOT_INSIDE_TYPEOF, &slow, &done);
|
| __ bind(&slow);
|
| - Comment cmnt(masm_, "Lookup slot");
|
| __ push(rsi); // Context.
|
| __ Push(var->name());
|
| __ CallRuntime(Runtime::kLoadContextSlot, 2);
|
| @@ -1656,7 +1664,7 @@ void FullCodeGenerator::VisitObjectLiteral(ObjectLiteral* expr) {
|
| VisitForAccumulatorValue(value);
|
| __ Move(rcx, key->value());
|
| __ movp(rdx, Operand(rsp, 0));
|
| - CallStoreIC(NOT_CONTEXTUAL, key->LiteralFeedbackId());
|
| + CallStoreIC(key->LiteralFeedbackId());
|
| PrepareForBailoutForId(key->id(), NO_REGISTERS);
|
| } else {
|
| VisitForEffect(value);
|
| @@ -2068,10 +2076,17 @@ void FullCodeGenerator::VisitYield(Yield* expr) {
|
|
|
| // result = receiver[f](arg);
|
| __ bind(&l_call);
|
| - Handle<Code> ic = isolate()->stub_cache()->ComputeKeyedCallInitialize(1);
|
| - CallIC(ic);
|
| + __ movp(rdx, Operand(rsp, kPointerSize));
|
| + __ movp(rax, Operand(rsp, 2 * kPointerSize));
|
| + Handle<Code> ic = isolate()->builtins()->KeyedLoadIC_Initialize();
|
| + CallIC(ic, TypeFeedbackId::None());
|
| + __ movp(rdi, rax);
|
| + __ movp(Operand(rsp, 2 * kPointerSize), rdi);
|
| + CallFunctionStub stub(1, CALL_AS_METHOD);
|
| + __ CallStub(&stub);
|
| +
|
| __ movp(rsi, Operand(rbp, StandardFrameConstants::kContextOffset));
|
| - __ Drop(1); // The key is still on the stack; drop it.
|
| + __ Drop(1); // The function is still on the stack; drop it.
|
|
|
| // if (!result.done) goto l_try;
|
| __ bind(&l_loop);
|
| @@ -2255,7 +2270,7 @@ void FullCodeGenerator::EmitNamedPropertyLoad(Property* prop) {
|
| void FullCodeGenerator::EmitKeyedPropertyLoad(Property* prop) {
|
| SetSourcePosition(prop->position());
|
| Handle<Code> ic = isolate()->builtins()->KeyedLoadIC_Initialize();
|
| - CallIC(ic, NOT_CONTEXTUAL, prop->PropertyFeedbackId());
|
| + CallIC(ic, prop->PropertyFeedbackId());
|
| }
|
|
|
|
|
| @@ -2277,8 +2292,7 @@ void FullCodeGenerator::EmitInlineSmiBinaryOp(BinaryOperation* expr,
|
| __ bind(&stub_call);
|
| __ movp(rax, rcx);
|
| BinaryOpICStub stub(op, mode);
|
| - CallIC(stub.GetCode(isolate()), NOT_CONTEXTUAL,
|
| - expr->BinaryOperationFeedbackId());
|
| + CallIC(stub.GetCode(isolate()), expr->BinaryOperationFeedbackId());
|
| patch_site.EmitPatchInfo();
|
| __ jmp(&done, Label::kNear);
|
|
|
| @@ -2327,8 +2341,7 @@ void FullCodeGenerator::EmitBinaryOp(BinaryOperation* expr,
|
| __ pop(rdx);
|
| BinaryOpICStub stub(op, mode);
|
| JumpPatchSite patch_site(masm_); // unbound, signals no inlined smi code.
|
| - CallIC(stub.GetCode(isolate()), NOT_CONTEXTUAL,
|
| - expr->BinaryOperationFeedbackId());
|
| + CallIC(stub.GetCode(isolate()), expr->BinaryOperationFeedbackId());
|
| patch_site.EmitPatchInfo();
|
| context()->Plug(rax);
|
| }
|
| @@ -2366,7 +2379,7 @@ void FullCodeGenerator::EmitAssignment(Expression* expr) {
|
| __ movp(rdx, rax);
|
| __ pop(rax); // Restore value.
|
| __ Move(rcx, prop->key()->AsLiteral()->value());
|
| - CallStoreIC(NOT_CONTEXTUAL);
|
| + CallStoreIC();
|
| break;
|
| }
|
| case KEYED_PROPERTY: {
|
| @@ -2387,44 +2400,58 @@ void FullCodeGenerator::EmitAssignment(Expression* expr) {
|
| }
|
|
|
|
|
| +void FullCodeGenerator::EmitStoreToStackLocalOrContextSlot(
|
| + Variable* var, MemOperand location) {
|
| + __ movp(location, rax);
|
| + if (var->IsContextSlot()) {
|
| + __ movp(rdx, rax);
|
| + __ RecordWriteContextSlot(
|
| + rcx, Context::SlotOffset(var->index()), rdx, rbx, kDontSaveFPRegs);
|
| + }
|
| +}
|
| +
|
| +
|
| +void FullCodeGenerator::EmitCallStoreContextSlot(
|
| + Handle<String> name, LanguageMode mode) {
|
| + __ push(rax); // Value.
|
| + __ push(rsi); // Context.
|
| + __ Push(name);
|
| + __ Push(Smi::FromInt(mode));
|
| + __ CallRuntime(Runtime::kStoreContextSlot, 4);
|
| +}
|
| +
|
| +
|
| void FullCodeGenerator::EmitVariableAssignment(Variable* var,
|
| Token::Value op) {
|
| if (var->IsUnallocated()) {
|
| // Global var, const, or let.
|
| __ Move(rcx, var->name());
|
| __ movp(rdx, GlobalObjectOperand());
|
| - CallStoreIC(CONTEXTUAL);
|
| + CallStoreIC();
|
| +
|
| } else if (op == Token::INIT_CONST) {
|
| // Const initializers need a write barrier.
|
| ASSERT(!var->IsParameter()); // No const parameters.
|
| - if (var->IsStackLocal()) {
|
| - Label skip;
|
| - __ movp(rdx, StackOperand(var));
|
| - __ CompareRoot(rdx, Heap::kTheHoleValueRootIndex);
|
| - __ j(not_equal, &skip);
|
| - __ movp(StackOperand(var), rax);
|
| - __ bind(&skip);
|
| - } else {
|
| - ASSERT(var->IsContextSlot() || var->IsLookupSlot());
|
| - // Like var declarations, const declarations are hoisted to function
|
| - // scope. However, unlike var initializers, const initializers are
|
| - // able to drill a hole to that function context, even from inside a
|
| - // 'with' context. We thus bypass the normal static scope lookup for
|
| - // var->IsContextSlot().
|
| + if (var->IsLookupSlot()) {
|
| __ push(rax);
|
| __ push(rsi);
|
| __ Push(var->name());
|
| __ CallRuntime(Runtime::kInitializeConstContextSlot, 3);
|
| + } else {
|
| + ASSERT(var->IsStackLocal() || var->IsContextSlot());
|
| + Label skip;
|
| + MemOperand location = VarOperand(var, rcx);
|
| + __ movp(rdx, location);
|
| + __ CompareRoot(rdx, Heap::kTheHoleValueRootIndex);
|
| + __ j(not_equal, &skip);
|
| + EmitStoreToStackLocalOrContextSlot(var, location);
|
| + __ bind(&skip);
|
| }
|
|
|
| } else if (var->mode() == LET && op != Token::INIT_LET) {
|
| // Non-initializing assignment to let variable needs a write barrier.
|
| if (var->IsLookupSlot()) {
|
| - __ push(rax); // Value.
|
| - __ push(rsi); // Context.
|
| - __ Push(var->name());
|
| - __ Push(Smi::FromInt(language_mode()));
|
| - __ CallRuntime(Runtime::kStoreContextSlot, 4);
|
| + EmitCallStoreContextSlot(var->name(), language_mode());
|
| } else {
|
| ASSERT(var->IsStackAllocated() || var->IsContextSlot());
|
| Label assign;
|
| @@ -2435,18 +2462,16 @@ void FullCodeGenerator::EmitVariableAssignment(Variable* var,
|
| __ Push(var->name());
|
| __ CallRuntime(Runtime::kThrowReferenceError, 1);
|
| __ bind(&assign);
|
| - __ movp(location, rax);
|
| - if (var->IsContextSlot()) {
|
| - __ movp(rdx, rax);
|
| - __ RecordWriteContextSlot(
|
| - rcx, Context::SlotOffset(var->index()), rdx, rbx, kDontSaveFPRegs);
|
| - }
|
| + EmitStoreToStackLocalOrContextSlot(var, location);
|
| }
|
|
|
| } else if (!var->is_const_mode() || op == Token::INIT_CONST_HARMONY) {
|
| // Assignment to var or initializing assignment to let/const
|
| // in harmony mode.
|
| - if (var->IsStackAllocated() || var->IsContextSlot()) {
|
| + if (var->IsLookupSlot()) {
|
| + EmitCallStoreContextSlot(var->name(), language_mode());
|
| + } else {
|
| + ASSERT(var->IsStackAllocated() || var->IsContextSlot());
|
| MemOperand location = VarOperand(var, rcx);
|
| if (generate_debug_code_ && op == Token::INIT_LET) {
|
| // Check for an uninitialized let binding.
|
| @@ -2454,20 +2479,7 @@ void FullCodeGenerator::EmitVariableAssignment(Variable* var,
|
| __ CompareRoot(rdx, Heap::kTheHoleValueRootIndex);
|
| __ Check(equal, kLetBindingReInitialization);
|
| }
|
| - // Perform the assignment.
|
| - __ movp(location, rax);
|
| - if (var->IsContextSlot()) {
|
| - __ movp(rdx, rax);
|
| - __ RecordWriteContextSlot(
|
| - rcx, Context::SlotOffset(var->index()), rdx, rbx, kDontSaveFPRegs);
|
| - }
|
| - } else {
|
| - ASSERT(var->IsLookupSlot());
|
| - __ push(rax); // Value.
|
| - __ push(rsi); // Context.
|
| - __ Push(var->name());
|
| - __ Push(Smi::FromInt(language_mode()));
|
| - __ CallRuntime(Runtime::kStoreContextSlot, 4);
|
| + EmitStoreToStackLocalOrContextSlot(var, location);
|
| }
|
| }
|
| // Non-initializing assignments to consts are ignored.
|
| @@ -2484,7 +2496,7 @@ void FullCodeGenerator::EmitNamedPropertyAssignment(Assignment* expr) {
|
| SetSourcePosition(expr->position());
|
| __ Move(rcx, prop->key()->AsLiteral()->value());
|
| __ pop(rdx);
|
| - CallStoreIC(NOT_CONTEXTUAL, expr->AssignmentFeedbackId());
|
| + CallStoreIC(expr->AssignmentFeedbackId());
|
|
|
| PrepareForBailoutForId(expr->AssignmentId(), TOS_REG);
|
| context()->Plug(rax);
|
| @@ -2501,7 +2513,7 @@ void FullCodeGenerator::EmitKeyedPropertyAssignment(Assignment* expr) {
|
| Handle<Code> ic = is_classic_mode()
|
| ? isolate()->builtins()->KeyedStoreIC_Initialize()
|
| : isolate()->builtins()->KeyedStoreIC_Initialize_Strict();
|
| - CallIC(ic, NOT_CONTEXTUAL, expr->AssignmentFeedbackId());
|
| + CallIC(ic, expr->AssignmentFeedbackId());
|
|
|
| PrepareForBailoutForId(expr->AssignmentId(), TOS_REG);
|
| context()->Plug(rax);
|
| @@ -2528,71 +2540,101 @@ void FullCodeGenerator::VisitProperty(Property* expr) {
|
|
|
|
|
| void FullCodeGenerator::CallIC(Handle<Code> code,
|
| - ContextualMode mode,
|
| TypeFeedbackId ast_id) {
|
| ic_total_count_++;
|
| - ASSERT(mode != CONTEXTUAL || ast_id.IsNone());
|
| __ call(code, RelocInfo::CODE_TARGET, ast_id);
|
| }
|
|
|
|
|
| -void FullCodeGenerator::EmitCallWithIC(Call* expr,
|
| - Handle<Object> name,
|
| - ContextualMode mode) {
|
| - // Code common for calls using the IC.
|
| +// Code common for calls using the IC.
|
| +void FullCodeGenerator::EmitCallWithIC(Call* expr) {
|
| + Expression* callee = expr->expression();
|
| ZoneList<Expression*>* args = expr->arguments();
|
| int arg_count = args->length();
|
| +
|
| + CallFunctionFlags flags;
|
| + // Get the target function;
|
| + if (callee->IsVariableProxy()) {
|
| + { StackValueContext context(this);
|
| + EmitVariableLoad(callee->AsVariableProxy());
|
| + PrepareForBailout(callee, NO_REGISTERS);
|
| + }
|
| + // Push undefined as receiver. This is patched in the method prologue if it
|
| + // is a classic mode method.
|
| + __ Push(isolate()->factory()->undefined_value());
|
| + flags = NO_CALL_FUNCTION_FLAGS;
|
| + } else {
|
| + // Load the function from the receiver.
|
| + ASSERT(callee->IsProperty());
|
| + __ movp(rax, Operand(rsp, 0));
|
| + EmitNamedPropertyLoad(callee->AsProperty());
|
| + PrepareForBailoutForId(callee->AsProperty()->LoadId(), TOS_REG);
|
| + // Push the target function under the receiver.
|
| + __ push(Operand(rsp, 0));
|
| + __ movp(Operand(rsp, kPointerSize), rax);
|
| + flags = CALL_AS_METHOD;
|
| + }
|
| +
|
| + // Load the arguments.
|
| { PreservePositionScope scope(masm()->positions_recorder());
|
| for (int i = 0; i < arg_count; i++) {
|
| VisitForStackValue(args->at(i));
|
| }
|
| - __ Move(rcx, name);
|
| }
|
| +
|
| // Record source position for debugger.
|
| SetSourcePosition(expr->position());
|
| - // Call the IC initialization code.
|
| - Handle<Code> ic = isolate()->stub_cache()->ComputeCallInitialize(arg_count);
|
| - TypeFeedbackId ast_id = mode == CONTEXTUAL
|
| - ? TypeFeedbackId::None()
|
| - : expr->CallFeedbackId();
|
| - CallIC(ic, mode, ast_id);
|
| + CallFunctionStub stub(arg_count, flags);
|
| + __ movp(rdi, Operand(rsp, (arg_count + 1) * kPointerSize));
|
| + __ CallStub(&stub);
|
| +
|
| RecordJSReturnSite(expr);
|
| +
|
| // Restore context register.
|
| __ movp(rsi, Operand(rbp, StandardFrameConstants::kContextOffset));
|
| - context()->Plug(rax);
|
| +
|
| + context()->DropAndPlug(1, rax);
|
| }
|
|
|
|
|
| +// Common code for calls using the IC.
|
| void FullCodeGenerator::EmitKeyedCallWithIC(Call* expr,
|
| Expression* key) {
|
| // Load the key.
|
| VisitForAccumulatorValue(key);
|
|
|
| - // Swap the name of the function and the receiver on the stack to follow
|
| - // the calling convention for call ICs.
|
| - __ pop(rcx);
|
| - __ push(rax);
|
| - __ push(rcx);
|
| -
|
| - // Load the arguments.
|
| + Expression* callee = expr->expression();
|
| ZoneList<Expression*>* args = expr->arguments();
|
| int arg_count = args->length();
|
| +
|
| + // Load the function from the receiver.
|
| + ASSERT(callee->IsProperty());
|
| + __ movp(rdx, Operand(rsp, 0));
|
| + EmitKeyedPropertyLoad(callee->AsProperty());
|
| + PrepareForBailoutForId(callee->AsProperty()->LoadId(), TOS_REG);
|
| +
|
| + // Push the target function under the receiver.
|
| + __ push(Operand(rsp, 0));
|
| + __ movp(Operand(rsp, kPointerSize), rax);
|
| +
|
| + // Load the arguments.
|
| { PreservePositionScope scope(masm()->positions_recorder());
|
| for (int i = 0; i < arg_count; i++) {
|
| VisitForStackValue(args->at(i));
|
| }
|
| }
|
| +
|
| // Record source position for debugger.
|
| SetSourcePosition(expr->position());
|
| - // Call the IC initialization code.
|
| - Handle<Code> ic =
|
| - isolate()->stub_cache()->ComputeKeyedCallInitialize(arg_count);
|
| - __ movp(rcx, Operand(rsp, (arg_count + 1) * kPointerSize)); // Key.
|
| - CallIC(ic, NOT_CONTEXTUAL, expr->CallFeedbackId());
|
| + CallFunctionStub stub(arg_count, CALL_AS_METHOD);
|
| + __ movp(rdi, Operand(rsp, (arg_count + 1) * kPointerSize));
|
| + __ CallStub(&stub);
|
| +
|
| RecordJSReturnSite(expr);
|
| // Restore context register.
|
| __ movp(rsi, Operand(rbp, StandardFrameConstants::kContextOffset));
|
| - context()->DropAndPlug(1, rax); // Drop the key still on the stack.
|
| +
|
| + context()->DropAndPlug(1, rax);
|
| }
|
|
|
|
|
| @@ -2609,15 +2651,15 @@ void FullCodeGenerator::EmitCallWithStub(Call* expr) {
|
| SetSourcePosition(expr->position());
|
|
|
| Handle<Object> uninitialized =
|
| - TypeFeedbackCells::UninitializedSentinel(isolate());
|
| - Handle<Cell> cell = isolate()->factory()->NewCell(uninitialized);
|
| - RecordTypeFeedbackCell(expr->CallFeedbackId(), cell);
|
| - __ Move(rbx, cell);
|
| + TypeFeedbackInfo::UninitializedSentinel(isolate());
|
| + StoreFeedbackVectorSlot(expr->CallFeedbackSlot(), uninitialized);
|
| + __ Move(rbx, FeedbackVector());
|
| + __ Move(rdx, Smi::FromInt(expr->CallFeedbackSlot()));
|
|
|
| // Record call targets in unoptimized code.
|
| CallFunctionStub stub(arg_count, RECORD_CALL_TARGET);
|
| __ movp(rdi, Operand(rsp, (arg_count + 1) * kPointerSize));
|
| - __ CallStub(&stub, expr->CallFeedbackId());
|
| + __ CallStub(&stub);
|
| RecordJSReturnSite(expr);
|
| // Restore context register.
|
| __ movp(rsi, Operand(rbp, StandardFrameConstants::kContextOffset));
|
| @@ -2695,11 +2737,8 @@ void FullCodeGenerator::VisitCall(Call* expr) {
|
| __ movp(rsi, Operand(rbp, StandardFrameConstants::kContextOffset));
|
| context()->DropAndPlug(1, rax);
|
| } else if (call_type == Call::GLOBAL_CALL) {
|
| - // Call to a global variable. Push global object as receiver for the
|
| - // call IC lookup.
|
| - __ push(GlobalObjectOperand());
|
| - VariableProxy* proxy = callee->AsVariableProxy();
|
| - EmitCallWithIC(expr, proxy->name(), CONTEXTUAL);
|
| + EmitCallWithIC(expr);
|
| +
|
| } else if (call_type == Call::LOOKUP_SLOT_CALL) {
|
| // Call to a lookup slot (dynamically introduced variable).
|
| VariableProxy* proxy = callee->AsVariableProxy();
|
| @@ -2742,9 +2781,7 @@ void FullCodeGenerator::VisitCall(Call* expr) {
|
| VisitForStackValue(property->obj());
|
| }
|
| if (property->key()->IsPropertyName()) {
|
| - EmitCallWithIC(expr,
|
| - property->key()->AsLiteral()->value(),
|
| - NOT_CONTEXTUAL);
|
| + EmitCallWithIC(expr);
|
| } else {
|
| EmitKeyedCallWithIC(expr, property->key());
|
| }
|
| @@ -2794,10 +2831,10 @@ void FullCodeGenerator::VisitCallNew(CallNew* expr) {
|
|
|
| // Record call targets in unoptimized code, but not in the snapshot.
|
| Handle<Object> uninitialized =
|
| - TypeFeedbackCells::UninitializedSentinel(isolate());
|
| - Handle<Cell> cell = isolate()->factory()->NewCell(uninitialized);
|
| - RecordTypeFeedbackCell(expr->CallNewFeedbackId(), cell);
|
| - __ Move(rbx, cell);
|
| + TypeFeedbackInfo::UninitializedSentinel(isolate());
|
| + StoreFeedbackVectorSlot(expr->CallNewFeedbackSlot(), uninitialized);
|
| + __ Move(rbx, FeedbackVector());
|
| + __ Move(rdx, Smi::FromInt(expr->CallNewFeedbackSlot()));
|
|
|
| CallConstructStub stub(RECORD_CALL_TARGET);
|
| __ Call(stub.GetCode(isolate()), RelocInfo::CONSTRUCT_CALL);
|
| @@ -3362,7 +3399,7 @@ void FullCodeGenerator::EmitDateField(CallRuntime* expr) {
|
| __ bind(&runtime);
|
| __ PrepareCallCFunction(2);
|
| __ movp(arg_reg_1, object);
|
| - __ Move(arg_reg_2, index, RelocInfo::NONE64);
|
| + __ Move(arg_reg_2, index, Assembler::RelocInfoNone());
|
| __ CallCFunction(ExternalReference::get_date_field_function(isolate()), 2);
|
| __ movp(rsi, Operand(rbp, StandardFrameConstants::kContextOffset));
|
| __ jmp(&done);
|
| @@ -3390,8 +3427,8 @@ void FullCodeGenerator::EmitOneByteSeqStringSetChar(CallRuntime* expr) {
|
| __ pop(index);
|
|
|
| if (FLAG_debug_code) {
|
| - __ ThrowIf(NegateCondition(__ CheckSmi(value)), kNonSmiValue);
|
| - __ ThrowIf(NegateCondition(__ CheckSmi(index)), kNonSmiValue);
|
| + __ Check(__ CheckSmi(value), kNonSmiValue);
|
| + __ Check(__ CheckSmi(index), kNonSmiValue);
|
| }
|
|
|
| __ SmiToInteger32(value, value);
|
| @@ -3423,8 +3460,8 @@ void FullCodeGenerator::EmitTwoByteSeqStringSetChar(CallRuntime* expr) {
|
| __ pop(index);
|
|
|
| if (FLAG_debug_code) {
|
| - __ ThrowIf(NegateCondition(__ CheckSmi(value)), kNonSmiValue);
|
| - __ ThrowIf(NegateCondition(__ CheckSmi(index)), kNonSmiValue);
|
| + __ Check(__ CheckSmi(value), kNonSmiValue);
|
| + __ Check(__ CheckSmi(index), kNonSmiValue);
|
| }
|
|
|
| __ SmiToInteger32(value, value);
|
| @@ -3610,21 +3647,12 @@ void FullCodeGenerator::EmitStringCharAt(CallRuntime* expr) {
|
| void FullCodeGenerator::EmitStringAdd(CallRuntime* expr) {
|
| ZoneList<Expression*>* args = expr->arguments();
|
| ASSERT_EQ(2, args->length());
|
| + VisitForStackValue(args->at(0));
|
| + VisitForAccumulatorValue(args->at(1));
|
|
|
| - if (FLAG_new_string_add) {
|
| - VisitForStackValue(args->at(0));
|
| - VisitForAccumulatorValue(args->at(1));
|
| -
|
| - __ pop(rdx);
|
| - NewStringAddStub stub(STRING_ADD_CHECK_BOTH, NOT_TENURED);
|
| - __ CallStub(&stub);
|
| - } else {
|
| - VisitForStackValue(args->at(0));
|
| - VisitForStackValue(args->at(1));
|
| -
|
| - StringAddStub stub(STRING_ADD_CHECK_BOTH);
|
| - __ CallStub(&stub);
|
| - }
|
| + __ pop(rdx);
|
| + StringAddStub stub(STRING_ADD_CHECK_BOTH, NOT_TENURED);
|
| + __ CallStub(&stub);
|
| context()->Plug(rax);
|
| }
|
|
|
| @@ -3700,7 +3728,9 @@ void FullCodeGenerator::EmitRegExpConstructResult(CallRuntime* expr) {
|
| ASSERT(args->length() == 3);
|
| VisitForStackValue(args->at(0));
|
| VisitForStackValue(args->at(1));
|
| - VisitForStackValue(args->at(2));
|
| + VisitForAccumulatorValue(args->at(2));
|
| + __ pop(rbx);
|
| + __ pop(rcx);
|
| __ CallStub(&stub);
|
| context()->Plug(rax);
|
| }
|
| @@ -3736,9 +3766,9 @@ void FullCodeGenerator::EmitGetFromCache(CallRuntime* expr) {
|
| FieldOperand(cache, FixedArray::OffsetOfElementAt(cache_id)));
|
|
|
| Label done, not_found;
|
| - // tmp now holds finger offset as a smi.
|
| STATIC_ASSERT(kSmiTag == 0 && kSmiTagSize == 1);
|
| __ movp(tmp, FieldOperand(cache, JSFunctionResultCache::kFingerOffset));
|
| + // tmp now holds finger offset as a smi.
|
| SmiIndex index =
|
| __ SmiToIndex(kScratchRegister, tmp, kPointerSizeLog2);
|
| __ cmpq(key, FieldOperand(cache,
|
| @@ -3763,45 +3793,6 @@ void FullCodeGenerator::EmitGetFromCache(CallRuntime* expr) {
|
| }
|
|
|
|
|
| -void FullCodeGenerator::EmitIsRegExpEquivalent(CallRuntime* expr) {
|
| - ZoneList<Expression*>* args = expr->arguments();
|
| - ASSERT_EQ(2, args->length());
|
| -
|
| - Register right = rax;
|
| - Register left = rbx;
|
| - Register tmp = rcx;
|
| -
|
| - VisitForStackValue(args->at(0));
|
| - VisitForAccumulatorValue(args->at(1));
|
| - __ pop(left);
|
| -
|
| - Label done, fail, ok;
|
| - __ cmpq(left, right);
|
| - __ j(equal, &ok, Label::kNear);
|
| - // Fail if either is a non-HeapObject.
|
| - Condition either_smi = masm()->CheckEitherSmi(left, right, tmp);
|
| - __ j(either_smi, &fail, Label::kNear);
|
| - __ j(zero, &fail, Label::kNear);
|
| - __ movp(tmp, FieldOperand(left, HeapObject::kMapOffset));
|
| - __ cmpb(FieldOperand(tmp, Map::kInstanceTypeOffset),
|
| - Immediate(JS_REGEXP_TYPE));
|
| - __ j(not_equal, &fail, Label::kNear);
|
| - __ cmpq(tmp, FieldOperand(right, HeapObject::kMapOffset));
|
| - __ j(not_equal, &fail, Label::kNear);
|
| - __ movp(tmp, FieldOperand(left, JSRegExp::kDataOffset));
|
| - __ cmpq(tmp, FieldOperand(right, JSRegExp::kDataOffset));
|
| - __ j(equal, &ok, Label::kNear);
|
| - __ bind(&fail);
|
| - __ Move(rax, isolate()->factory()->false_value());
|
| - __ jmp(&done, Label::kNear);
|
| - __ bind(&ok);
|
| - __ Move(rax, isolate()->factory()->true_value());
|
| - __ bind(&done);
|
| -
|
| - context()->Plug(rax);
|
| -}
|
| -
|
| -
|
| void FullCodeGenerator::EmitHasCachedArrayIndex(CallRuntime* expr) {
|
| ZoneList<Expression*>* args = expr->arguments();
|
| ASSERT(args->length() == 1);
|
| @@ -4135,30 +4126,47 @@ void FullCodeGenerator::VisitCallRuntime(CallRuntime* expr) {
|
|
|
| Comment cmnt(masm_, "[ CallRuntime");
|
| ZoneList<Expression*>* args = expr->arguments();
|
| + int arg_count = args->length();
|
|
|
| if (expr->is_jsruntime()) {
|
| - // Prepare for calling JS runtime function.
|
| + // Push the builtins object as receiver.
|
| __ movp(rax, GlobalObjectOperand());
|
| __ push(FieldOperand(rax, GlobalObject::kBuiltinsOffset));
|
| - }
|
|
|
| - // Push the arguments ("left-to-right").
|
| - int arg_count = args->length();
|
| - for (int i = 0; i < arg_count; i++) {
|
| - VisitForStackValue(args->at(i));
|
| - }
|
| -
|
| - if (expr->is_jsruntime()) {
|
| - // Call the JS runtime function using a call IC.
|
| + // Load the function from the receiver.
|
| + __ movp(rax, Operand(rsp, 0));
|
| __ Move(rcx, expr->name());
|
| - Handle<Code> ic = isolate()->stub_cache()->ComputeCallInitialize(arg_count);
|
| - CallIC(ic, NOT_CONTEXTUAL, expr->CallRuntimeFeedbackId());
|
| + CallLoadIC(NOT_CONTEXTUAL, expr->CallRuntimeFeedbackId());
|
| +
|
| + // Push the target function under the receiver.
|
| + __ push(Operand(rsp, 0));
|
| + __ movp(Operand(rsp, kPointerSize), rax);
|
| +
|
| + // Push the arguments ("left-to-right").
|
| + for (int i = 0; i < arg_count; i++) {
|
| + VisitForStackValue(args->at(i));
|
| + }
|
| +
|
| + // Record source position of the IC call.
|
| + SetSourcePosition(expr->position());
|
| + CallFunctionStub stub(arg_count, NO_CALL_FUNCTION_FLAGS);
|
| + __ movp(rdi, Operand(rsp, (arg_count + 1) * kPointerSize));
|
| + __ CallStub(&stub);
|
| +
|
| // Restore context register.
|
| __ movp(rsi, Operand(rbp, StandardFrameConstants::kContextOffset));
|
| + context()->DropAndPlug(1, rax);
|
| +
|
| } else {
|
| + // Push the arguments ("left-to-right").
|
| + for (int i = 0; i < arg_count; i++) {
|
| + VisitForStackValue(args->at(i));
|
| + }
|
| +
|
| + // Call the C runtime.
|
| __ CallRuntime(expr->function(), arg_count);
|
| + context()->Plug(rax);
|
| }
|
| - context()->Plug(rax);
|
| }
|
|
|
|
|
| @@ -4402,9 +4410,7 @@ void FullCodeGenerator::VisitCountOperation(CountOperation* expr) {
|
| __ movp(rdx, rax);
|
| __ Move(rax, Smi::FromInt(1));
|
| BinaryOpICStub stub(expr->binary_op(), NO_OVERWRITE);
|
| - CallIC(stub.GetCode(isolate()),
|
| - NOT_CONTEXTUAL,
|
| - expr->CountBinOpFeedbackId());
|
| + CallIC(stub.GetCode(isolate()), expr->CountBinOpFeedbackId());
|
| patch_site.EmitPatchInfo();
|
| __ bind(&done);
|
|
|
| @@ -4435,7 +4441,7 @@ void FullCodeGenerator::VisitCountOperation(CountOperation* expr) {
|
| case NAMED_PROPERTY: {
|
| __ Move(rcx, prop->key()->AsLiteral()->value());
|
| __ pop(rdx);
|
| - CallStoreIC(NOT_CONTEXTUAL, expr->CountStoreFeedbackId());
|
| + CallStoreIC(expr->CountStoreFeedbackId());
|
| PrepareForBailoutForId(expr->AssignmentId(), TOS_REG);
|
| if (expr->is_postfix()) {
|
| if (!context()->IsEffect()) {
|
| @@ -4452,7 +4458,7 @@ void FullCodeGenerator::VisitCountOperation(CountOperation* expr) {
|
| Handle<Code> ic = is_classic_mode()
|
| ? isolate()->builtins()->KeyedStoreIC_Initialize()
|
| : isolate()->builtins()->KeyedStoreIC_Initialize_Strict();
|
| - CallIC(ic, NOT_CONTEXTUAL, expr->CountStoreFeedbackId());
|
| + CallIC(ic, expr->CountStoreFeedbackId());
|
| PrepareForBailoutForId(expr->AssignmentId(), TOS_REG);
|
| if (expr->is_postfix()) {
|
| if (!context()->IsEffect()) {
|
| @@ -4473,7 +4479,7 @@ void FullCodeGenerator::VisitForTypeofValue(Expression* expr) {
|
| ASSERT(!context()->IsTest());
|
|
|
| if (proxy != NULL && proxy->var()->IsUnallocated()) {
|
| - Comment cmnt(masm_, "Global variable");
|
| + Comment cmnt(masm_, "[ Global variable");
|
| __ Move(rcx, proxy->name());
|
| __ movp(rax, GlobalObjectOperand());
|
| // Use a regular load, not a contextual load, to avoid a reference
|
| @@ -4482,6 +4488,7 @@ void FullCodeGenerator::VisitForTypeofValue(Expression* expr) {
|
| PrepareForBailout(expr, TOS_REG);
|
| context()->Plug(rax);
|
| } else if (proxy != NULL && proxy->var()->IsLookupSlot()) {
|
| + Comment cmnt(masm_, "[ Lookup slot");
|
| Label done, slow;
|
|
|
| // Generate code for loading from variables potentially shadowed
|
| @@ -4640,7 +4647,7 @@ void FullCodeGenerator::VisitCompareOperation(CompareOperation* expr) {
|
| // Record position and call the compare IC.
|
| SetSourcePosition(expr->position());
|
| Handle<Code> ic = CompareIC::GetUninitialized(isolate(), op);
|
| - CallIC(ic, NOT_CONTEXTUAL, expr->CompareOperationFeedbackId());
|
| + CallIC(ic, expr->CompareOperationFeedbackId());
|
| patch_site.EmitPatchInfo();
|
|
|
| PrepareForBailoutBeforeSplit(expr, true, if_true, if_false);
|
| @@ -4675,7 +4682,7 @@ void FullCodeGenerator::EmitLiteralCompareNil(CompareOperation* expr,
|
| Split(equal, if_true, if_false, fall_through);
|
| } else {
|
| Handle<Code> ic = CompareNilICStub::GetUninitialized(isolate(), nil);
|
| - CallIC(ic, NOT_CONTEXTUAL, expr->CompareOperationFeedbackId());
|
| + CallIC(ic, expr->CompareOperationFeedbackId());
|
| __ testq(rax, rax);
|
| Split(not_zero, if_true, if_false, fall_through);
|
| }
|
|
|