Experimental parser: merge to r19637

test/cctest/test-debug.cc

 // Copyright 2012 the V8 project authors. All rights reserved.
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
 //
 //     * Redistributions of source code must retain the above copyright
 //       notice, this list of conditions and the following disclaimer.
 //     * Redistributions in binary form must reproduce the above
 //       copyright notice, this list of conditions and the following
 //       disclaimer in the documentation and/or other materials provided
@@ skipping 370 matching lines @@
   count = 0;
   while (node) {
     debugged_functions->set(count++, *node->debug_info());
     node = node->next();
   }
 
   return debugged_functions;
 }
 
 
-static Handle<Code> ComputeCallDebugBreak(int argc) {
-  return CcTest::i_isolate()->stub_cache()->ComputeCallDebugBreak(argc,
-                                                                 Code::CALL_IC);
-}
-
-
 // Check that the debugger has been fully unloaded.
 void CheckDebuggerUnloaded(bool check_functions) {
   // Check that the debugger context is cleared and that there is no debug
   // information stored for the debugger.
   CHECK(CcTest::i_isolate()->debug()->debug_context().is_null());
   CHECK_EQ(NULL, CcTest::i_isolate()->debug()->debug_info_list_);
 
   // Collect garbage to ensure weak handles are cleared.
   CcTest::heap()->CollectAllGarbage(Heap::kNoGCFlags);
   CcTest::heap()->CollectAllGarbage(Heap::kMakeHeapIterableMask);
@@ skipping 670 matching lines @@
       &env,
       "function f6(a){return a==null;}",
       "f6",
       0,
       v8::internal::RelocInfo::CODE_TARGET,
       CcTest::i_isolate()->builtins()->builtin(
           Builtins::kCompareNilIC_DebugBreak));
 
   // Check the debug break code stubs for call ICs with different number of
   // parameters.
-  Handle<Code> debug_break_0 = v8::internal::ComputeCallDebugBreak(0);
-  Handle<Code> debug_break_1 = v8::internal::ComputeCallDebugBreak(1);
-  Handle<Code> debug_break_4 = v8::internal::ComputeCallDebugBreak(4);
+  // TODO(verwaest): XXX update test.
+  // Handle<Code> debug_break_0 = v8::internal::ComputeCallDebugBreak(0);
+  // Handle<Code> debug_break_1 = v8::internal::ComputeCallDebugBreak(1);
+  // Handle<Code> debug_break_4 = v8::internal::ComputeCallDebugBreak(4);
 
-  CheckDebugBreakFunction(&env,
-                          "function f4_0(){x();}", "f4_0",
-                          0,
-                          v8::internal::RelocInfo::CODE_TARGET,
-                          *debug_break_0);
+  // CheckDebugBreakFunction(&env,
+  //                         "function f4_0(){x();}", "f4_0",
+  //                         0,
+  //                         v8::internal::RelocInfo::CODE_TARGET,
+  //                         *debug_break_0);
 
-  CheckDebugBreakFunction(&env,
-                          "function f4_1(){x(1);}", "f4_1",
-                          0,
-                          v8::internal::RelocInfo::CODE_TARGET,
-                          *debug_break_1);
+  // CheckDebugBreakFunction(&env,
+  //                         "function f4_1(){x(1);}", "f4_1",
+  //                         0,
+  //                         v8::internal::RelocInfo::CODE_TARGET,
+  //                         *debug_break_1);
 
-  CheckDebugBreakFunction(&env,
-                          "function f4_4(){x(1,2,3,4);}", "f4_4",
-                          0,
-                          v8::internal::RelocInfo::CODE_TARGET,
-                          *debug_break_4);
+  // CheckDebugBreakFunction(&env,
+  //                         "function f4_4(){x(1,2,3,4);}", "f4_4",
+  //                         0,
+  //                         v8::internal::RelocInfo::CODE_TARGET,
+  //                         *debug_break_4);
 }
 
 
 // Test that the debug info in the VM is in sync with the functions being
 // debugged.
 TEST(DebugInfo) {
   DebugLocalContext env;
   v8::HandleScope scope(env->GetIsolate());
   // Create a couple of functions for the test.
   v8::Local<v8::Function> foo =
@@ skipping 6580 matching lines @@
 
 TEST(LiveEditDisabled) {
   v8::internal::FLAG_allow_natives_syntax = true;
   LocalContext env;
   v8::HandleScope scope(env->GetIsolate());
   v8::Debug::SetLiveEditEnabled(false, env->GetIsolate());
   CompileRun("%LiveEditCompareStrings('', '')");
 }
 
 
+TEST(PrecompiledFunction) {
+  // Regression test for crbug.com/346207. If we have preparse data, parsing the
+  // function in the presence of the debugger (and breakpoints) should still
+  // succeed. The bug was that preparsing was done lazily and parsing was done
+  // eagerly, so, the symbol streams didn't match.
+  DebugLocalContext env;
+  v8::HandleScope scope(env->GetIsolate());
+  env.ExposeDebug();
+  v8::Debug::SetDebugEventListener2(DebugBreakInlineListener);
+
+  v8::Local<v8::Function> break_here =
+      CompileFunction(&env, "function break_here(){}", "break_here");
+  SetBreakPoint(break_here, 0);
+
+  const char* source =
+      "var a = b = c = 1;              \n"
+      "function this_is_lazy() {       \n"
+      // This symbol won't appear in the preparse data.
+      "  var a;                        \n"
+      "}                               \n"
+      "function bar() {                \n"
+      "  return \"bar\";               \n"
+      "};                              \n"
+      "a = b = c = 2;                  \n"
+      "bar();                          \n";
+  v8::Local<v8::Value> result = PreCompileCompileRun(source);
+  CHECK(result->IsString());
+  v8::String::Utf8Value utf8(result);
+  CHECK_EQ("bar", *utf8);
+
+  v8::Debug::SetDebugEventListener2(NULL);
+  CheckDebuggerUnloaded();
+}
+
+
 #endif  // ENABLE_DEBUGGER_SUPPORT