webkit/browser/fileapi/test_file_system_backend.cc - Issue 18565002: [FileSystem] Add another copy-or-move validation hook for post-write.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webkit/browser/fileapi/test_file_system_backend.cc

Issue 18565002: [FileSystem] Add another copy-or-move validation hook for post-write. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Test fixes Created 7 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: webkit/browser/fileapi/test_file_system_backend.cc

diff --git a/webkit/browser/fileapi/test_file_system_backend.cc b/webkit/browser/fileapi/test_file_system_backend.cc

index 700cc0de2a2dfe5e9dedc7d1561617a643d700cd..0640069a7dd5f8bb48dc25c04a0159d8650ad9ec 100644

--- a/webkit/browser/fileapi/test_file_system_backend.cc

+++ b/webkit/browser/fileapi/test_file_system_backend.cc

@@ -182,6 +182,7 @@ TestFileSystemBackend::GetCopyOrMoveFileValidatorFactory(

void TestFileSystemBackend::InitializeCopyOrMoveFileValidatorFactory(

scoped_ptr<CopyOrMoveFileValidatorFactory> factory) {

+ // What purpose is this check serving?

vandebo (ex-Chrome) 2013/07/18 17:35:14 nit: remove/resolve this question

Greg Billock 2013/07/30 23:18:31 removing it -- my guess is it is remnant test code

if (!require_copy_or_move_validator_) {

DCHECK(!factory);

return;