Implement ServiceWorker::postMessage() [Blink]

Source/modules/serviceworkers/ServiceWorker.cpp

 /*
  * Copyright (C) 2013 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 13 matching lines @@
  * LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
  * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
  * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
  * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
  * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
  */
 
 #include "config.h"
 #include "ServiceWorker.h"
 
+#include "bindings/v8/ExceptionState.h"
+#include "core/dom/MessagePort.h"
+#include "public/platform/WebMessagePortChannel.h"
+#include "public/platform/WebString.h"
 
 namespace WebCore {
 
 ServiceWorker::ServiceWorker(PassOwnPtr<blink::WebServiceWorker> worker)
     : m_outerWorker(worker)
 {
 }
 
+void ServiceWorker::postMessage(PassRefPtr<SerializedScriptValue> message, const MessagePortArray* ports, ExceptionState& exceptionState)
+{
+    // Disentangle the port in preparation for sending it to the remote context.
+    OwnPtr<MessagePortChannelArray> channels = MessagePort::disentanglePorts(ports, exceptionState);
+    if (exceptionState.hadException())
+        return;
+
+    blink::WebString messageString = message->toWireString();
+    blink::WebMessagePortChannelArray* webChannels = 0;
+    if (channels && channels->size()) {

[adamk, 2014/03/19 17:48:58]

It makes me sad to see another version of this loop (the leakPtr especially is
looks bad). Any chance of sharing this with the code in
MessagePort::postMessage() (and maybe WebDOMMessageEvent::releaseChannels,
though that one is odd since it uses a stack-allocated WebVector)?

[jsbell, 2014/03/19 21:06:47]

This factors out pretty cleanly (I didn't touch releaseChannels); I ended up
putting it in MessagePort for lack of better inspiration.

+        webChannels = new blink::WebMessagePortChannelArray(channels->size());
+        for (size_t i = 0; i < channels->size(); ++i)
+            (*webChannels)[i] = (*channels)[i].leakPtr();
+    }
+    m_outerWorker->postMessage(messageString, webChannels);
+}
+
 } // namespace WebCore