Issue 185643003: Changes to use the modified dart API for

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 185643003: Changes to use the modified dart API for (Closed)

Created:
6 years, 9 months ago by siva

Modified:
6 years, 9 months ago

Reviewers:
vsm, Ivan Posva

CC:
reviews+dom_dartlang.org

Base URL:
svn://svn.chromium.org/blink/branches/dart/1750/

Visibility:
Public.

Changes to use the modified dart API for Dart_WeakPersistentHandleFinalizer and Dart_DeleteWeakPersistentHandle This requires https://codereview.chromium.org/186003002/ R=vsm@google.com Committed: https://src.chromium.org/viewvc/multivm/branches/1650/blink?view=rev&revision=168398

Created: 6 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+13 lines, -11 lines)			Patch
M	Source/bindings/dart/DartDOMWrapper.h	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	Source/bindings/dart/DartEventListener.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/bindings/dart/DartEventListener.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/bindings/dart/DartStringCache.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/bindings/dart/DartStringCache.cpp	View	2 chunks	+6 lines, -4 lines	0 comments	Download
M	Source/bindings/dart/DartUtilities.cpp	View	1 chunk	+2 lines, -2 lines	0 comments	Download

Total messages: 4 (0 generated)

siva

6 years, 9 months ago (2014-03-04 18:12:06 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 manually as r168398 (presubmit successful).