src/wasm/decoder.h - Issue 1856413002: [wasm] Refactor decoding of local declarations and make more robust.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/wasm/decoder.h

Issue 1856413002: [wasm] Refactor decoding of local declarations and make more robust. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/wasm/decoder.h

diff --git a/src/wasm/decoder.h b/src/wasm/decoder.h

index 8b4e1bd223c6afd072b91a7ae54ad5d065412ae3..f9de2e1143fb71451a7e7bbbd04f9d30190dfd90 100644

--- a/src/wasm/decoder.h

+++ b/src/wasm/decoder.h

@@ -329,7 +329,7 @@ class Decoder {

}

bool ok() const { return error_pc_ == nullptr; }

- bool failed() const { return error_pc_ != nullptr; }

+ bool failed() const { return !error_msg_.is_empty(); }

bool more() const { return pc_ < limit_; }

const byte* start() { return start_; }

« no previous file with comments | « src/wasm/ast-decoder.cc ('k') | test/unittests/wasm/ast-decoder-unittest.cc » ('j') | no next file with comments »