[wasm] Refactor decoding of local declarations and make more robust.

[wasm] Refactor decoding of local declarations and make more robust.

R=ahaas@chromium.org
BUG=

Committed: https://crrev.com/6dda75f23b191c6a8b4147ce3dec3353949a5a6a
Cr-Commit-Position: refs/heads/master@{#35272}

[ahaas, 2016-04-05 17:04:30]

lgtm

https://codereview.chromium.org/1856413002/diff/1/src/wasm/ast-decoder.cc
File src/wasm/ast-decoder.cc (right):

https://codereview.chromium.org/1856413002/diff/1/src/wasm/ast-decoder.cc#new...
src/wasm/ast-decoder.cc:428: decls.total_local_count += count;
Is it actually possible that decls.total_local_count != local_type_vec_.size()?
If not, then the value should be assigned outside the loop.

https://codereview.chromium.org/1856413002/diff/1/test/unittests/wasm/ast-dec...
File test/unittests/wasm/ast-decoder-unittest.cc (right):

https://codereview.chromium.org/1856413002/diff/1/test/unittests/wasm/ast-dec...
test/unittests/wasm/ast-decoder-unittest.cc:2250: EXPECT_EQ(type, map.at(0));
Wouldn't map[0] also work here?

[titzer, 2016-04-05 17:14:23]

https://codereview.chromium.org/1856413002/diff/1/src/wasm/ast-decoder.cc
File src/wasm/ast-decoder.cc (right):

https://codereview.chromium.org/1856413002/diff/1/src/wasm/ast-decoder.cc#new...
src/wasm/ast-decoder.cc:428: decls.total_local_count += count;
On 2016/04/05 17:04:30, ahaas wrote:
> Is it actually possible that decls.total_local_count !=
local_type_vec_.size()?
> If not, then the value should be assigned outside the loop.

Good catch. Done.

https://codereview.chromium.org/1856413002/diff/1/test/unittests/wasm/ast-dec...
File test/unittests/wasm/ast-decoder-unittest.cc (right):

https://codereview.chromium.org/1856413002/diff/1/test/unittests/wasm/ast-dec...
test/unittests/wasm/ast-decoder-unittest.cc:2250: EXPECT_EQ(type, map.at(0));
On 2016/04/05 17:04:30, ahaas wrote:
> Wouldn't map[0] also work here?

Done.

[titzer, 2016-04-05 17:14:29]

The CQ bit was checked by titzer@chromium.org

[commit-bot: I haz the power, 2016-04-05 17:14:32]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1856413002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1856413002/40001

[commit-bot: I haz the power, 2016-04-05 17:16:15]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-04-05 17:16:39]

Description was changed from

==========
[wasm] Refactor decoding of local declarations and make more robust.

R=ahaas@chromium.org
BUG=
==========

to

==========
[wasm] Refactor decoding of local declarations and make more robust.

R=ahaas@chromium.org
BUG=

Committed: https://crrev.com/6dda75f23b191c6a8b4147ce3dec3353949a5a6a
Cr-Commit-Position: refs/heads/master@{#35272}
==========

[commit-bot: I haz the power, 2016-04-05 17:16:40]

Patchset 3 (id:??) landed as
https://crrev.com/6dda75f23b191c6a8b4147ce3dec3353949a5a6a
Cr-Commit-Position: refs/heads/master@{#35272}

[titzer, 2016-04-05 17:17:38]

On 2016/04/05 17:16:40, commit-bot: I haz the power wrote:
> Patchset 3 (id:??) landed as
> https://crrev.com/6dda75f23b191c6a8b4147ce3dec3353949a5a6a
> Cr-Commit-Position: refs/heads/master@{#35272}

Whoops, those suggestions didn't make it into my patchset.

Will upload another.