Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(570)

Unified Diff: third_party/WebKit/Source/core/layout/PaginationTest.cpp

Issue 1856373002: Only allow forced fragmentainer breaks at class A break points. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Woho! LayoutTests/printing/css2.1/page-break-after-003.html now passes. Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/core/layout/LayoutBox.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/layout/PaginationTest.cpp
diff --git a/third_party/WebKit/Source/core/layout/PaginationTest.cpp b/third_party/WebKit/Source/core/layout/PaginationTest.cpp
index 7df64f8dc652e04f96c77aeb5387dfea033125d3..ecc4dd66402df75f1834d4d29675c9c05aa0ad23 100644
--- a/third_party/WebKit/Source/core/layout/PaginationTest.cpp
+++ b/third_party/WebKit/Source/core/layout/PaginationTest.cpp
@@ -145,8 +145,10 @@ TEST_F(PaginationStrutTest, InnerBlockWithBreakBefore)
"</div>");
EXPECT_EQ(0, strutForBox("block1"));
EXPECT_EQ(0, strutForLine("block1", 0));
- EXPECT_EQ(0, strutForBox("block2"));
- EXPECT_EQ(48, strutForBox("innerBlock"));
+ // There's no class A break point before #innerBlock (they only exist *between* siblings), so
+ // the break is propagated and applied before #block2.
+ EXPECT_EQ(50, strutForBox("block2"));
+ EXPECT_EQ(0, strutForBox("innerBlock"));
EXPECT_EQ(0, strutForLine("innerBlock", 0));
}
« no previous file with comments | « third_party/WebKit/Source/core/layout/LayoutBox.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698