Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(467)

Unified Diff: third_party/WebKit/Source/core/layout/ColumnBalancer.h

Issue 1856373002: Only allow forced fragmentainer breaks at class A break points. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Woho! LayoutTests/printing/css2.1/page-break-after-003.html now passes. Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/layout/ColumnBalancer.h
diff --git a/third_party/WebKit/Source/core/layout/ColumnBalancer.h b/third_party/WebKit/Source/core/layout/ColumnBalancer.h
index 65328dcaabbecac15e076d1a59f34a2876e99c1f..e559e05a4028d6c9e98489e128e02412e8cde9b6 100644
--- a/third_party/WebKit/Source/core/layout/ColumnBalancer.h
+++ b/third_party/WebKit/Source/core/layout/ColumnBalancer.h
@@ -18,6 +18,8 @@ protected:
// Flow thread offset for the layout object that we're currently examining.
LayoutUnit flowThreadOffset() const { return m_flowThreadOffset; }
+ EBreak previousBreakAfterValue() const { return m_previousBreakAfterValue; }
+
// Return true if the specified offset is at the top of a column, as long as it's not the first
// column in the fragmentainer group.
bool isFirstAfterBreak(LayoutUnit flowThreadOffset) const
@@ -63,6 +65,10 @@ private:
const MultiColumnFragmentainerGroup& m_group;
LayoutUnit m_flowThreadOffset;
+
+ // The break-after value from the previous in-flow block-level object to be joined with the
+ // break-before value of the next in-flow block-level object.
+ EBreak m_previousBreakAfterValue;
};
// After an initial layout pass, we know the height of the contents of a flow thread. Based on

Powered by Google App Engine
This is Rietveld 408576698