Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(808)

Unified Diff: public/platform/WebAnimationDelegate.h

Issue 185633002: Adding monotonic only API to Blink's animation delegate interface (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Rebase onto HEAD. Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/web/tests/ImageLayerChromiumTest.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: public/platform/WebAnimationDelegate.h
diff --git a/public/platform/WebAnimationDelegate.h b/public/platform/WebAnimationDelegate.h
index e233e5db69bf11b7f16f433d82d7eb5651dd1458..d628815d66adc7bc778ffdaaca6613f38bd93b16 100644
--- a/public/platform/WebAnimationDelegate.h
+++ b/public/platform/WebAnimationDelegate.h
@@ -33,10 +33,18 @@ namespace blink {
class WebAnimationDelegate {
public:
- // FIXME: Remove wallClockTime once the legacy implementation of CSS
- // animations and transitions is removed.
- virtual void notifyAnimationStarted(double wallClockTime, double monotonicTime, WebAnimation::TargetProperty) = 0;
- virtual void notifyAnimationFinished(double wallClockTime, double monotonicTime, WebAnimation::TargetProperty) = 0;
+ // TODO: Removed wallClockTime after the following file is updated;
ajuma 2014/03/03 15:25:21 Nit: Blink style is to use "FIXME" rather than "TO
mithro-old 2014/03/04 01:39:18 Done.
+ // webkit/renderer/compositor_bindings/web_to_cc_animation_delegate_adapter.cc
+ inline void notifyAnimationStarted(double wallClockTime, double monotonicTime, WebAnimation::TargetProperty prop)
+ {
+ notifyAnimationStarted(monotonicTime, prop);
+ }
+ inline void notifyAnimationFinished(double wallClockTime, double monotonicTime, WebAnimation::TargetProperty prop)
+ {
+ notifyAnimationFinished(monotonicTime, prop);
+ }
+ virtual void notifyAnimationStarted(double monotonicTime, WebAnimation::TargetProperty) = 0;
ajuma 2014/03/03 15:25:21 If this CL lands first (as in the steps you've des
ajuma 2014/03/03 15:30:27 Actually, ignore the "this will have no implementa
mithro-old 2014/03/04 01:39:18 Adding BLINK_PLATFORM_EXPORT should fix windows. T
+ virtual void notifyAnimationFinished(double monotonicTime, WebAnimation::TargetProperty) = 0;
};
} // namespace blink
« no previous file with comments | « Source/web/tests/ImageLayerChromiumTest.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698