Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(475)

Side by Side Diff: public/platform/WebAnimationDelegate.h

Issue 185633002: Adding monotonic only API to Blink's animation delegate interface (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Rebase onto HEAD. Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « Source/web/tests/ImageLayerChromiumTest.cpp ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2012 Google Inc. All rights reserved. 2 * Copyright (C) 2012 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 1. Redistributions of source code must retain the above copyright 7 * 1. Redistributions of source code must retain the above copyright
8 * notice, this list of conditions and the following disclaimer. 8 * notice, this list of conditions and the following disclaimer.
9 * 2. Redistributions in binary form must reproduce the above copyright 9 * 2. Redistributions in binary form must reproduce the above copyright
10 * notice, this list of conditions and the following disclaimer in the 10 * notice, this list of conditions and the following disclaimer in the
(...skipping 15 matching lines...) Expand all
26 #define WebAnimationDelegate_h 26 #define WebAnimationDelegate_h
27 27
28 #include "WebAnimation.h" 28 #include "WebAnimation.h"
29 29
30 #define WEB_ANIMATION_DELEGATE_TAKES_MONOTONIC_TIME 1 30 #define WEB_ANIMATION_DELEGATE_TAKES_MONOTONIC_TIME 1
31 31
32 namespace blink { 32 namespace blink {
33 33
34 class WebAnimationDelegate { 34 class WebAnimationDelegate {
35 public: 35 public:
36 // FIXME: Remove wallClockTime once the legacy implementation of CSS 36 // TODO: Removed wallClockTime after the following file is updated;
ajuma 2014/03/03 15:25:21 Nit: Blink style is to use "FIXME" rather than "TO
mithro-old 2014/03/04 01:39:18 Done.
37 // animations and transitions is removed. 37 // webkit/renderer/compositor_bindings/web_to_cc_animation_delegate_adapter. cc
38 virtual void notifyAnimationStarted(double wallClockTime, double monotonicTi me, WebAnimation::TargetProperty) = 0; 38 inline void notifyAnimationStarted(double wallClockTime, double monotonicTim e, WebAnimation::TargetProperty prop)
39 virtual void notifyAnimationFinished(double wallClockTime, double monotonicT ime, WebAnimation::TargetProperty) = 0; 39 {
40 notifyAnimationStarted(monotonicTime, prop);
41 }
42 inline void notifyAnimationFinished(double wallClockTime, double monotonicTi me, WebAnimation::TargetProperty prop)
43 {
44 notifyAnimationFinished(monotonicTime, prop);
45 }
46 virtual void notifyAnimationStarted(double monotonicTime, WebAnimation::Targ etProperty) = 0;
ajuma 2014/03/03 15:25:21 If this CL lands first (as in the steps you've des
ajuma 2014/03/03 15:30:27 Actually, ignore the "this will have no implementa
mithro-old 2014/03/04 01:39:18 Adding BLINK_PLATFORM_EXPORT should fix windows. T
47 virtual void notifyAnimationFinished(double monotonicTime, WebAnimation::Tar getProperty) = 0;
40 }; 48 };
41 49
42 } // namespace blink 50 } // namespace blink
43 51
44 #endif // WebAnimationDelegate_h 52 #endif // WebAnimationDelegate_h
OLDNEW
« no previous file with comments | « Source/web/tests/ImageLayerChromiumTest.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698