Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(96)

Issue 1856303002: [X87] [Crankshaft] Fix DoMathFloor and DoMathRound code generation bug. (Closed)

Created:
4 years, 8 months ago by zhengxing.li
Modified:
4 years, 8 months ago
Reviewers:
Weiliang, chunyang.dai
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[X87] [Crankshaft] Fix DoMathFloor and DoMathRound code generation bug. The CL #35067 (https://codereview.chromium.org/1830703003) exposed one hidden bug in x87 crankshaft code generation for DoMathFloor and DoMathRound. The current DoMathFloor will change the default round mode of x87 FPU and then deoptimized into FC code before the default x87 FPU's round mode was restored. This behavior caused several test cases fail as the FC code expected to run under the default x87 FPU's round mode. This CL fixed this bug. BUG= Committed: https://crrev.com/da477bc7e284f2eb07f9f79a5214525c482d3c55 Cr-Commit-Position: refs/heads/master@{#35250}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M src/crankshaft/x87/lithium-codegen-x87.cc View 3 chunks +5 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
zhengxing.li
PTAL, thanks!
4 years, 8 months ago (2016-04-05 06:02:44 UTC) #2
Weiliang
lgtm
4 years, 8 months ago (2016-04-05 06:55:42 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1856303002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1856303002/1
4 years, 8 months ago (2016-04-05 06:56:23 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-05 07:16:01 UTC) #6
commit-bot: I haz the power
4 years, 8 months ago (2016-04-05 07:16:24 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/da477bc7e284f2eb07f9f79a5214525c482d3c55
Cr-Commit-Position: refs/heads/master@{#35250}

Powered by Google App Engine
This is Rietveld 408576698