Refactor gyp_chromium to ease reuse.

Refactor gyp_chromium to ease reuse.

Moves the new Visual Studio 2013 toolchain logic and
download into a helper function. That way it can easily be used
by client projects that have their own gyp_* files.
See http://review.webrtc.org/7759004/ for an example.

NOTRY=True
TEST=Successful local execution on Mac and Windows.

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=254626

[kjellander_chromium, 2014-03-03 06:30:35]

This would make it easier for us to adapt to the new toolchain in our gyp
script.
No changes to the contents of the function are made.

[scottmg, 2014-03-03 17:18:43]

lgtm with a couple caveat/fyis:
- the toolchain isn't "everything", I just added pieces until chrome build, so
you might have trouble with that
- the sha1s passed from here to depot_tools are a bit problematic at the moment
-- they have to be updated in src/ and in depot_tools at the same time, because
depot_tools doesn't actually handle getting anything other than "head" right
now.

[kjellander_chromium, 2014-03-03 23:50:13]

On 2014/03/03 17:18:43, scottmg wrote:
> lgtm with a couple caveat/fyis:
> - the toolchain isn't "everything", I just added pieces until chrome build, so
> you might have trouble with that

You mean trouble building WebRTC standalone? That's fine it seems to be enough
when I tried compiling.

> - the sha1s passed from here to depot_tools are a bit problematic at the
moment
> -- they have to be updated in src/ and in depot_tools at the same time,
because
> depot_tools doesn't actually handle getting anything other than "head" right
> now.

That shouldn't be a problem for us. In WebRTC standalone checkouts we sync out a
copy of Chromium's src/build toolchain using our DEPS, so whenever we roll our
Chromium revision, we will get updates to this file as well in a controlled
manner.

[kjellander_chromium, 2014-03-04 01:10:53]

The CQ bit was checked by kjellander@chromium.org

[commit-bot: I haz the power, 2014-03-04 01:13:38]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/kjellander@chromium.org/185623004/80001

[commit-bot: I haz the power, 2014-03-04 01:16:10]

Change committed as 254626