Add Hide and Show to the app list SearchBoxView.

Add Hide and Show to the app list SearchBoxView.

This CL adds a Show and Hide to the app list SearchBoxView in preparation
for work pertaining to the experimental app list. The Show and Hide also
require that the AppListView's background repaints which have required
changes to the AppListView, AppListMainView and SearchBoxViewDelegate.

BUG=349727
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=255899

[tapted, 2014-03-04 05:27:01]

is there a tracker bug for fancy-new-app-launcher?

https://codereview.chromium.org/185623002/diff/1/ui/app_list/views/app_list_v...
File ui/app_list/views/app_list_view.cc (right):

https://codereview.chromium.org/185623002/diff/1/ui/app_list/views/app_list_v...
ui/app_list/views/app_list_view.cc:193: void AppListView::RepaintBackground() {
calls to `SchedulePaint()` propagate up through to the root of the view
hierarchy. Can you just add an override:

virtual void AppListView::SchedulePaintInRect(const gfx::Rect& rect) {
  BubbleDelegateView::SchedulePaintInRect(rect);
  GetBubbleFrameView()->SchedulePaint();
}

[calamity, 2014-03-05 04:39:53]

> is there a tracker bug for fancy-new-app-launcher?
> 

There's a tracker bug for the positioning but not for the other aspects of it...

>
https://codereview.chromium.org/185623002/diff/1/ui/app_list/views/app_list_v...
> File ui/app_list/views/app_list_view.cc (right):
> 
>
https://codereview.chromium.org/185623002/diff/1/ui/app_list/views/app_list_v...
> ui/app_list/views/app_list_view.cc:193: void AppListView::RepaintBackground()
{
> calls to `SchedulePaint()` propagate up through to the root of the view
> hierarchy. Can you just add an override:
> 
> virtual void AppListView::SchedulePaintInRect(const gfx::Rect& rect) {
>   BubbleDelegateView::SchedulePaintInRect(rect);
>   GetBubbleFrameView()->SchedulePaint();
> }

It seems like I can't! At least, not in isolation. SchedulePaint doesn't
propagate through views
that are SetPaintToLayer(true) such as the AppListMainView. =(

Looking through the View stuff, looks like I can use a few of the notifications
there
instead of making my own.

[calamity, 2014-03-05 05:06:44]

Uploaded patch set that uses more built in View stuff. We could also make the
AppListMainView call SchedulePaint on parent() rather than passing in
AppListView. Any preference?

[tapted, 2014-03-05 05:27:38]

On 2014/03/05 04:39:53, calamity wrote:
> > is there a tracker bug for fancy-new-app-launcher?
> > 
> 
> There's a tracker bug for the positioning but not for the other aspects of
it...
> 
> >
>
https://codereview.chromium.org/185623002/diff/1/ui/app_list/views/app_list_v...
> > File ui/app_list/views/app_list_view.cc (right):
> > 
> >
>
https://codereview.chromium.org/185623002/diff/1/ui/app_list/views/app_list_v...
> > ui/app_list/views/app_list_view.cc:193: void
AppListView::RepaintBackground()
> {
> > calls to `SchedulePaint()` propagate up through to the root of the view
> > hierarchy. Can you just add an override:
> > 
> > virtual void AppListView::SchedulePaintInRect(const gfx::Rect& rect) {
> >   BubbleDelegateView::SchedulePaintInRect(rect);
> >   GetBubbleFrameView()->SchedulePaint();
> > }
> 
> It seems like I can't! At least, not in isolation. SchedulePaint doesn't
> propagate through views
> that are SetPaintToLayer(true) such as the AppListMainView. =(

Oooh - this might be an indication that we need to move the layer higher up in
the hierarchy. I think you will need this anyway, since you can't animate the
"whole" MainView smoothly until it's painted into a layer (as opposed to just
its contents being painted into a layer).

It might be as simple as calling `SetPaintToLayer(true);` in
AppListView::InitAsBubbleInternal(..) (i.e. on `this`), and removing the other
calls to SetPaintToLayer (on app_list_main_view_ and speech_view_).

> Looking through the View stuff, looks like I can use a few of the
notifications
> there
> instead of making my own.

On 2014/03/05 05:06:44, calamity wrote:
> Uploaded patch set that uses more built in View stuff. We could also make the
> AppListMainView call SchedulePaint on parent() rather than passing in
> AppListView. Any preference?

Yep - just using parent() would be nicer. It better that the MainView doesn't
need to know the type of its superview.

[calamity, 2014-03-06 03:11:24]

On 2014/03/05 05:27:38, tapted wrote:
> On 2014/03/05 04:39:53, calamity wrote:
> > > is there a tracker bug for fancy-new-app-launcher?
> > > 
> > 
> > There's a tracker bug for the positioning but not for the other aspects of
> it...
> > 
> > >
> >
>
https://codereview.chromium.org/185623002/diff/1/ui/app_list/views/app_list_v...
> > > File ui/app_list/views/app_list_view.cc (right):
> > > 
> > >
> >
>
https://codereview.chromium.org/185623002/diff/1/ui/app_list/views/app_list_v...
> > > ui/app_list/views/app_list_view.cc:193: void
> AppListView::RepaintBackground()
> > {
> > > calls to `SchedulePaint()` propagate up through to the root of the view
> > > hierarchy. Can you just add an override:
> > > 
> > > virtual void AppListView::SchedulePaintInRect(const gfx::Rect& rect) {
> > >   BubbleDelegateView::SchedulePaintInRect(rect);
> > >   GetBubbleFrameView()->SchedulePaint();
> > > }
> > 
> > It seems like I can't! At least, not in isolation. SchedulePaint doesn't
> > propagate through views
> > that are SetPaintToLayer(true) such as the AppListMainView. =(
> 
> Oooh - this might be an indication that we need to move the layer higher up in
> the hierarchy. I think you will need this anyway, since you can't animate the
> "whole" MainView smoothly until it's painted into a layer (as opposed to just
> its contents being painted into a layer).
> 

Doing this causes ChromeOS to crash when you open the speech view. This happens
because OnSpeechRecognitionStateChanged uses these layers to animate showing
the speech view. =(

> It might be as simple as calling `SetPaintToLayer(true);` in
> AppListView::InitAsBubbleInternal(..) (i.e. on `this`), and removing the other
> calls to SetPaintToLayer (on app_list_main_view_ and speech_view_).
> 
> > Looking through the View stuff, looks like I can use a few of the
> notifications
> > there
> > instead of making my own.
> 
> On 2014/03/05 05:06:44, calamity wrote:
> > Uploaded patch set that uses more built in View stuff. We could also make
the
> > AppListMainView call SchedulePaint on parent() rather than passing in
> > AppListView. Any preference?
> 
> Yep - just using parent() would be nicer. It better that the MainView doesn't
> need to know the type of its superview.

Done.

[tapted, 2014-03-06 03:27:38]

lgtm

[calamity, 2014-03-06 07:29:01]

The CQ bit was checked by calamity@chromium.org

[commit-bot: I haz the power, 2014-03-06 07:29:46]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/calamity@chromium.org/185623002/80001

[commit-bot: I haz the power, 2014-03-06 07:50:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-03-06 07:50:14]

Try jobs failed on following builders: linux_chromium_clang_dbg

[calamity, 2014-03-06 23:48:54]

The CQ bit was checked by calamity@chromium.org

[commit-bot: I haz the power, 2014-03-06 23:55:40]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/calamity@chromium.org/185623002/80001

[commit-bot: I haz the power, 2014-03-07 02:31:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-03-07 02:31:02]

Try jobs failed on following builders: linux_chromium_clang_dbg

[calamity, 2014-03-07 03:22:31]

The CQ bit was checked by calamity@chromium.org

[commit-bot: I haz the power, 2014-03-07 03:24:54]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/calamity@chromium.org/185623002/80001

[commit-bot: I haz the power, 2014-03-07 06:04:30]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-03-07 06:04:30]

Try jobs failed on following builders: linux_chromium_chromeos_clang_dbg,
linux_chromium_clang_dbg

[calamity, 2014-03-07 06:07:10]

The CQ bit was checked by calamity@chromium.org

[commit-bot: I haz the power, 2014-03-07 06:07:56]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/calamity@chromium.org/185623002/80001

[commit-bot: I haz the power, 2014-03-07 07:02:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-03-07 07:02:14]

Try jobs failed on following builders: linux_chromium_chromeos_clang_dbg

[calamity, 2014-03-09 01:37:14]

The CQ bit was checked by calamity@chromium.org

[commit-bot: I haz the power, 2014-03-09 01:37:24]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/calamity@chromium.org/185623002/80001

[commit-bot: I haz the power, 2014-03-09 02:05:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-03-09 02:05:44]

Try jobs failed on following builders: linux_chromium_chromeos_clang_dbg

[calamity, 2014-03-09 23:51:53]

The CQ bit was checked by calamity@chromium.org

[commit-bot: I haz the power, 2014-03-09 23:52:04]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/calamity@chromium.org/185623002/100001

[commit-bot: I haz the power, 2014-03-10 07:17:12]

Change committed as 255899