[V8] Added DebugEvaluateContext to DCHECKs in contexts.cc

src/contexts.cc

 // Copyright 2011 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "src/contexts.h"
 
 #include "src/ast/scopeinfo.h"
 #include "src/bootstrapper.h"
 #include "src/debug/debug.h"
 #include "src/isolate-inl.h"
@@ skipping 72 matching lines @@
   Context* current = this;
   while (!current->IsFunctionContext() && !current->IsScriptContext() &&
          !current->IsNativeContext()) {
     current = current->previous();
     DCHECK(current->closure() == closure());
   }
   return current;
 }
 
 JSObject* Context::extension_object() {
-  DCHECK(IsNativeContext() || IsFunctionContext() || IsBlockContext());
+  DCHECK(IsNativeContext() || IsFunctionContext() || IsBlockContext() ||
+         IsDebugEvaluateContext());

[Yang, 2016/04/05 08:28:01]

I don't think this can happen. We don't even expect a with-context at this
point.

   HeapObject* object = extension();
   if (object->IsTheHole()) return nullptr;
   if (IsBlockContext()) {
     if (!object->IsSloppyBlockWithEvalContextExtension()) return nullptr;
     object = SloppyBlockWithEvalContextExtension::cast(object)->extension();
   }
-  DCHECK(object->IsJSContextExtensionObject() ||
+  DCHECK(object->IsJSContextExtensionObject() || IsDebugEvaluateContext() ||
          (IsNativeContext() && object->IsJSGlobalObject()));
   return JSObject::cast(object);
 }
 
 
 JSReceiver* Context::extension_receiver() {
-  DCHECK(IsNativeContext() || IsWithContext() ||
-         IsFunctionContext() || IsBlockContext());
+  DCHECK(IsNativeContext() || IsWithContext() || IsFunctionContext() ||
+         IsBlockContext() || IsDebugEvaluateContext());

[Yang, 2016/04/05 08:28:01]

This should not happen. The only place I can see this being called with a
debug-evaluate context is from the ScopeIterator. It should however not expose
debug-evaluate contexts. Otherwise it might be confusing for the user.

   return IsWithContext() ? JSReceiver::cast(extension()) : extension_object();
 }
 
 
 ScopeInfo* Context::scope_info() {
   DCHECK(IsModuleContext() || IsScriptContext() || IsBlockContext());
   HeapObject* object = extension();
   if (object->IsSloppyBlockWithEvalContextExtension()) {
     DCHECK(IsBlockContext());
     object = SloppyBlockWithEvalContextExtension::cast(object)->scope_info();
@@ skipping 463 matching lines @@
 
   int previous_value = errors_thrown()->value();
   set_errors_thrown(Smi::FromInt(previous_value + 1));
 }
 
 
 int Context::GetErrorsThrown() { return errors_thrown()->value(); }
 
 }  // namespace internal
 }  // namespace v8