Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(708)

Unified Diff: chrome/utility/media_galleries/picasa_albums_indexer.h

Issue 18562007: Media Galleries API Picasa: Put INI indexing step into sandboxed utility process. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@0035-picasa-import-sandbox-pmp-reading
Patch Set: Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/utility/media_galleries/picasa_albums_indexer.h
diff --git a/chrome/utility/media_galleries/picasa_albums_indexer.h b/chrome/utility/media_galleries/picasa_albums_indexer.h
index 6bf9993511b79baa44d5b5eb379809fcb169b7fa..cb6f1499980a32d21737262a0f0e7f12ddba8e4f 100644
--- a/chrome/utility/media_galleries/picasa_albums_indexer.h
+++ b/chrome/utility/media_galleries/picasa_albums_indexer.h
@@ -13,13 +13,8 @@
namespace picasa {
-// Defined outside of class because used by IPC messages.
-typedef std::set<base::FilePath> AlbumImages;
-typedef std::set<std::string> AlbumUUIDSet;
-typedef std::map<std::string, AlbumImages> AlbumImagesMap;
-
// Parses a series of INI files and builds up the set of files contained within
-// the albums passed in through |album_uuids|.
+// the albums passed in through |album_uids|.
//
// Each INI file only describes the images contained within a single directory.
// To build the contents of all the albums, we read in all the INI files
@@ -28,7 +23,7 @@ typedef std::map<std::string, AlbumImages> AlbumImagesMap;
// The INI albums also contain ".album*" sections describing the albums that
// have pictures in the same directory as the INI. However, we use the PMP
// database as the authoritative source on Album metadata, so we ignore those
-// sections. The PMP derived |album_uuids| are passed in by the constructor.
+// sections. The PMP derived |album_uids| are passed in by the constructor.
//
// Example INI File:
//
@@ -48,7 +43,7 @@ typedef std::map<std::string, AlbumImages> AlbumImagesMap;
// albums=18cb2df48aaa98e1c276b45cfcd81c95
class PicasaAlbumsIndexer {
public:
- explicit PicasaAlbumsIndexer(const AlbumUUIDSet& album_uuids);
+ explicit PicasaAlbumsIndexer(const AlbumUIDSet& album_uids);
Lei Zhang 2013/07/02 22:08:17 I think you need to #include chrome/common/media_g
tommycli 2013/07/03 00:58:28 Done.
~PicasaAlbumsIndexer();
// This method should be called once for each Folder in the PMP database.

Powered by Google App Engine
This is Rietveld 408576698