Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1856183002:
[Android] Add mb configurations for the android bots on chromium.gpu. (Closed)
Description[Android] Add mb configurations for the android bots on chromium.gpu.
BUG=577008
Committed: https://crrev.com/4e3f09c67d73ae2d3365594ec3911201a279ab49
Cr-Commit-Position: refs/heads/master@{#385751}
Patch Set 1 #Patch Set 2 : rebase #Messages
Total messages: 16 (4 generated)
jbudorick@chromium.org changed reviewers: + dpranke@chromium.org, kbr@chromium.org
Thanks. lgtm if this is their actual configuration. I'm not sure they're actually arm64.
On 2016/04/04 23:01:12, Ken Russell wrote: > Thanks. lgtm if this is their actual configuration. I'm not sure they're > actually arm64. The N9 is not, but we've been configuring our other N9s that way iirc. If you'd prefer to leave it as arm, I can change this.
On 2016/04/04 23:02:20, jbudorick wrote: > On 2016/04/04 23:01:12, Ken Russell wrote: > > Thanks. lgtm if this is their actual configuration. I'm not sure they're > > actually arm64. > > The N9 is not, but we've been configuring our other N9s that way iirc. If you'd > prefer to leave it as arm, I can change this. Either way is fine as long as the bots still compile and run. The bots are red right now due to http://crbug.com/600003 . Could you please wait for that to be resolved and for the bots to go green again before switching them to mb?
On 2016/04/04 23:13:38, Ken Russell wrote: > On 2016/04/04 23:02:20, jbudorick wrote: > > On 2016/04/04 23:01:12, Ken Russell wrote: > > > Thanks. lgtm if this is their actual configuration. I'm not sure they're > > > actually arm64. > > > > The N9 is not, but we've been configuring our other N9s that way iirc. If > you'd > > prefer to leave it as arm, I can change this. > > Either way is fine as long as the bots still compile and run. > > The bots are red right now due to http://crbug.com/600003 . Could you please > wait for that to be resolved and for the bots to go green again before switching > them to mb? Ah, I didn't realize that had been filed. This CL doesn't switch them to mb. It's just preparation for https://codereview.chromium.org/1857053002/, which does.
On 2016/04/04 23:16:38, jbudorick wrote: > On 2016/04/04 23:13:38, Ken Russell wrote: > > On 2016/04/04 23:02:20, jbudorick wrote: > > > On 2016/04/04 23:01:12, Ken Russell wrote: > > > > Thanks. lgtm if this is their actual configuration. I'm not sure they're > > > > actually arm64. > > > > > > The N9 is not, but we've been configuring our other N9s that way iirc. If > > you'd > > > prefer to leave it as arm, I can change this. > > > > Either way is fine as long as the bots still compile and run. > > > > The bots are red right now due to http://crbug.com/600003 . Could you please > > wait for that to be resolved and for the bots to go green again before > switching > > them to mb? > > Ah, I didn't realize that had been filed. > > This CL doesn't switch them to mb. It's just preparation for > https://codereview.chromium.org/1857053002/, which does. Understood. I'm mainly asking you to please track that and make sure the switchover doesn't happen until they're green. Too many things for me to keep track of right now. Thanks.
On 2016/04/04 23:24:12, Ken Russell wrote: > On 2016/04/04 23:16:38, jbudorick wrote: > > On 2016/04/04 23:13:38, Ken Russell wrote: > > > On 2016/04/04 23:02:20, jbudorick wrote: > > > > On 2016/04/04 23:01:12, Ken Russell wrote: > > > > > Thanks. lgtm if this is their actual configuration. I'm not sure they're > > > > > actually arm64. > > > > > > > > The N9 is not, but we've been configuring our other N9s that way iirc. If > > > you'd > > > > prefer to leave it as arm, I can change this. > > > > > > Either way is fine as long as the bots still compile and run. > > > > > > The bots are red right now due to http://crbug.com/600003 . Could you please > > > wait for that to be resolved and for the bots to go green again before > > switching > > > them to mb? > > > > Ah, I didn't realize that had been filed. > > > > This CL doesn't switch them to mb. It's just preparation for > > https://codereview.chromium.org/1857053002/, which does. > > Understood. I'm mainly asking you to please track that and make sure the > switchover doesn't happen until they're green. Too many things for me to keep > track of right now. Thanks. ah, yeah, I can certainly do that.
lgtm; feel free to land when kbr signs off.
On 2016/04/04 23:25:21, jbudorick wrote: > On 2016/04/04 23:24:12, Ken Russell wrote: > > On 2016/04/04 23:16:38, jbudorick wrote: > > > On 2016/04/04 23:13:38, Ken Russell wrote: > > > > On 2016/04/04 23:02:20, jbudorick wrote: > > > > > On 2016/04/04 23:01:12, Ken Russell wrote: > > > > > > Thanks. lgtm if this is their actual configuration. I'm not sure > they're > > > > > > actually arm64. > > > > > > > > > > The N9 is not, but we've been configuring our other N9s that way iirc. > If > > > > you'd > > > > > prefer to leave it as arm, I can change this. > > > > > > > > Either way is fine as long as the bots still compile and run. > > > > > > > > The bots are red right now due to http://crbug.com/600003 . Could you > please > > > > wait for that to be resolved and for the bots to go green again before > > > switching > > > > them to mb? > > > > > > Ah, I didn't realize that had been filed. > > > > > > This CL doesn't switch them to mb. It's just preparation for > > > https://codereview.chromium.org/1857053002/, which does. > > > > Understood. I'm mainly asking you to please track that and make sure the > > switchover doesn't happen until they're green. Too many things for me to keep > > track of right now. Thanks. > > ah, yeah, I can certainly do that. All three bots are now green, so I'm moving forward with this.
The CQ bit was checked by jbudorick@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from dpranke@chromium.org, kbr@chromium.org Link to the patchset: https://codereview.chromium.org/1856183002/#ps20001 (title: "rebase")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1856183002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1856183002/20001
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== [Android] Add mb configurations for the android bots on chromium.gpu. BUG=577008 ========== to ========== [Android] Add mb configurations for the android bots on chromium.gpu. BUG=577008 Committed: https://crrev.com/4e3f09c67d73ae2d3365594ec3911201a279ab49 Cr-Commit-Position: refs/heads/master@{#385751} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/4e3f09c67d73ae2d3365594ec3911201a279ab49 Cr-Commit-Position: refs/heads/master@{#385751} |
