Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(682)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1856123005: Convert receiver when calling an Api accessor. (Closed)

Created:
4 years, 8 months ago by Igor Sheludko
Modified:
4 years, 8 months ago
Reviewers:
Toon Verwaest
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Convert receiver when calling an Api accessor. BUG=chromium:590071 LOG=N Committed: https://crrev.com/03953f52bd4a184983a551927c406be6489ef89b Cr-Commit-Position: refs/heads/master@{#35282}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+61 lines, -11 lines) Patch
M src/builtins.cc View 2 chunks +14 lines, -1 line 0 comments Download
M src/execution.cc View 1 chunk +0 lines, -10 lines 0 comments Download
M test/cctest/test-api.cc View 1 chunk +47 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1856123005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1856123005/1
4 years, 8 months ago (2016-04-05 15:14:43 UTC) #2
Igor Sheludko
PTAL
4 years, 8 months ago (2016-04-05 15:14:53 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 8 months ago (2016-04-05 15:41:05 UTC) #6
Toon Verwaest
lgtm
4 years, 8 months ago (2016-04-06 07:32:41 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1856123005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1856123005/1
4 years, 8 months ago (2016-04-06 07:58:19 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-06 08:00:21 UTC) #10
commit-bot: I haz the power
4 years, 8 months ago (2016-04-06 08:02:30 UTC) #12
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/03953f52bd4a184983a551927c406be6489ef89b
Cr-Commit-Position: refs/heads/master@{#35282}

Powered by Google App Engine
This is Rietveld 408576698