Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(472)

Unified Diff: net/http/http_stream_factory_impl_unittest.cc

Issue 1856073002: Coalesce small buffers in net::BidirectionalStream (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: self review Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/http/http_stream_factory_impl_unittest.cc
diff --git a/net/http/http_stream_factory_impl_unittest.cc b/net/http/http_stream_factory_impl_unittest.cc
index e4f060c6e3ac848f80704a2ecd71917374b19223..d6c8162750d48bc7d2a81d34d941923fab6167bb 100644
--- a/net/http/http_stream_factory_impl_unittest.cc
+++ b/net/http/http_stream_factory_impl_unittest.cc
@@ -747,7 +747,7 @@ class TestBidirectionalDelegate : public BidirectionalStreamImpl::Delegate {
const SpdyHeaderBlock& response_headers() const { return response_headers_; }
private:
- void OnHeadersSent() override {}
+ void OnStreamReady() override {}
void OnHeadersReceived(const SpdyHeaderBlock& response_headers) override {
response_headers_ = response_headers;
loop_.Quit();
@@ -1622,7 +1622,8 @@ TEST_P(HttpStreamFactoryBidirectionalQuicTest,
bidi_request_info.priority = LOWEST;
TestBidirectionalDelegate delegate;
- stream_impl->Start(&bidi_request_info, BoundNetLog(), &delegate, nullptr);
+ stream_impl->Start(&bidi_request_info, BoundNetLog(), false, &delegate,
+ nullptr);
delegate.WaitUntilDone();
scoped_refptr<IOBuffer> buffer = new net::IOBuffer(1);
@@ -1747,7 +1748,8 @@ TEST_P(HttpStreamFactoryBidirectionalQuicTest,
bidi_request_info.priority = LOWEST;
TestBidirectionalDelegate delegate;
- stream_impl->Start(&bidi_request_info, BoundNetLog(), &delegate, nullptr);
+ stream_impl->Start(&bidi_request_info, BoundNetLog(), false, &delegate,
+ nullptr);
delegate.WaitUntilDone();
// Make sure the BidirectionalStream negotiated goes through QUIC.

Powered by Google App Engine
This is Rietveld 408576698