Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(308)

Unified Diff: net/http/bidirectional_stream_impl.h

Issue 1856073002: Coalesce small buffers in net::BidirectionalStream (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address Andrei's comments Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/http/bidirectional_stream_impl.h
diff --git a/net/http/bidirectional_stream_impl.h b/net/http/bidirectional_stream_impl.h
index 3f82e6f6e413eb0ca3d923a2c7919cea4387d175..4a54518eaa1976084a416b4c55498bbdfab8e391 100644
--- a/net/http/bidirectional_stream_impl.h
+++ b/net/http/bidirectional_stream_impl.h
@@ -35,13 +35,13 @@ class NET_EXPORT_PRIVATE BidirectionalStreamImpl {
public:
Delegate();
- // Called when the request headers have been sent.
+ // Called when the stream is ready for reading and writing.
// The delegate may call BidirectionalStreamImpl::ReadData to start reading,
// call BidirectionalStreamImpl::SendData to send data,
// or call BidirectionalStreamImpl::Cancel to cancel the stream.
// The delegate should not call BidirectionalStreamImpl::Cancel
// during this callback.
- virtual void OnHeadersSent() = 0;
+ virtual void OnStreamReady() = 0;
// Called when response headers are received.
// This is called at most once for the lifetime of a stream.
@@ -90,6 +90,7 @@ class NET_EXPORT_PRIVATE BidirectionalStreamImpl {
// Starts the BidirectionalStreamImpl and sends request headers.
virtual void Start(const BidirectionalStreamRequestInfo* request_info,
const BoundNetLog& net_log,
+ bool disable_auto_flush,
BidirectionalStreamImpl::Delegate* delegate,
scoped_ptr<base::Timer> timer) = 0;
@@ -107,6 +108,10 @@ class NET_EXPORT_PRIVATE BidirectionalStreamImpl {
// will have an END_STREAM flag.
virtual void SendData(IOBuffer* data, int length, bool end_stream) = 0;
+ virtual void SendvData(const std::vector<IOBuffer*>& buffers,
+ const std::vector<int>& lengths,
+ bool end_stream) = 0;
+
// Cancels the stream. No Delegate method will be called. Any pending
// operations may or may not succeed.
virtual void Cancel() = 0;

Powered by Google App Engine
This is Rietveld 408576698