Coalesce small buffers in net::BidirectionalStream

net/quic/quic_chromium_client_stream.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "net/quic/quic_chromium_client_stream.h"
 
 #include "base/callback_helpers.h"
 #include "base/location.h"
 #include "base/thread_task_runner_handle.h"
 #include "net/base/io_buffer.h"
@@ skipping 121 matching lines @@
   // Writes the data, or buffers it.
   WriteOrBufferData(data, fin, nullptr);
   if (!HasBufferedData()) {
     return OK;
   }
 
   callback_ = callback;
   return ERR_IO_PENDING;
 }
 
+int QuicChromiumClientStream::WritevStreamData(
+    const std::vector<IOBuffer*>& buffers,
+    const std::vector<int>& lengths,
+    bool fin,
+    const CompletionCallback& callback) {
+  // We should not have data buffered.

[Ryan Hamilton, 2016/04/26 16:52:16]

nit: avoid first person in comments. For example:

// Must not be called when data is buffered.

[xunjieli, 2016/04/26 18:11:26]

Done.

+  DCHECK(!HasBufferedData());
+  // Writes the data, or buffers it.
+  for (size_t i = 0; i < buffers.size(); ++i) {
+    bool is_fin = fin && (i == buffers.size() - 1);
+    base::StringPiece string_data(buffers[i]->data(), lengths[i]);
+    WriteOrBufferData(string_data, is_fin, nullptr);
+  }
+  if (!HasBufferedData()) {
+    return OK;
+  }
+
+  callback_ = callback;
+  return ERR_IO_PENDING;
+}
+
 void QuicChromiumClientStream::SetDelegate(
     QuicChromiumClientStream::Delegate* delegate) {
   DCHECK(!(delegate_ && delegate));
   delegate_ = delegate;
   while (!delegate_tasks_.empty()) {
     base::Closure closure = delegate_tasks_.front();
     delegate_tasks_.pop_front();
     closure.Run();
   }
   if (delegate == nullptr && sequencer()->IsClosed()) {
@@ skipping 79 matching lines @@
   } else {
     delegate_tasks_.push_back(closure);
   }
 }
 
 void QuicChromiumClientStream::DisableConnectionMigration() {
   can_migrate_ = false;
 }
 
 }  // namespace net