Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(49)

Issue 1856033002: Add SK_API to SkROBuffer::Iter (Closed)

Created:
4 years, 8 months ago by scroggo_chromium
Modified:
4 years, 8 months ago
Reviewers:
djsollen
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Add SK_API to SkROBuffer::Iter Necessary for crrev.com/1812273003 in Chromium. Also remove trailing whitespace. GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1856033002 Committed: https://skia.googlesource.com/skia/+/af0ba653bf47bae2683603ab89c9dba7dd0449ed

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -6 lines) Patch
M include/core/SkRWBuffer.h View 3 chunks +6 lines, -6 lines 0 comments Download

Messages

Total messages: 9 (5 generated)
scroggo_chromium
(follow-up to crrev.com/1838463003)
4 years, 8 months ago (2016-04-04 16:34:44 UTC) #4
djsollen
lgtm
4 years, 8 months ago (2016-04-04 16:48:29 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1856033002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1856033002/1
4 years, 8 months ago (2016-04-04 16:56:15 UTC) #7
commit-bot: I haz the power
4 years, 8 months ago (2016-04-04 17:05:27 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/af0ba653bf47bae2683603ab89c9dba7dd0449ed

Powered by Google App Engine
This is Rietveld 408576698