Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(426)

Issue 185603002: Update and analyzer snapshot with AST -> Ast rename. (Closed)

Created:
6 years, 9 months ago by scheglov
Modified:
6 years, 9 months ago
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Tweak for analyzer version in 'intl' package. #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+2685 lines, -4965 lines) Patch
M editor/util/plugins/com.google.dart.java2dart/resources/ast_include.dart View 4 chunks +5 lines, -5 lines 0 comments Download
M editor/util/plugins/com.google.dart.java2dart/src/com/google/dart/java2dart/engine/MainEngine.java View 6 chunks +6 lines, -6 lines 0 comments Download
D editor/util/plugins/com.google.dart.java2dart/src/com/google/dart/java2dart/util/ASTFactory.java View 1 chunk +0 lines, -1388 lines 0 comments Download
A + editor/util/plugins/com.google.dart.java2dart/src/com/google/dart/java2dart/util/AstFactory.java View 0 chunks +-1 lines, --1 lines 0 comments Download
M pkg/analyzer/example/parser_driver.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/analyzer/example/resolver_driver.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/analyzer/lib/src/generated/ast.dart View 373 chunks +1356 lines, -1636 lines 0 comments Download
M pkg/analyzer/lib/src/generated/constant.dart View 20 chunks +17 lines, -21 lines 0 comments Download
M pkg/analyzer/lib/src/generated/element.dart View 136 chunks +10 lines, -279 lines 0 comments Download
M pkg/analyzer/lib/src/generated/engine.dart View 33 chunks +12 lines, -62 lines 0 comments Download
M pkg/analyzer/lib/src/generated/error.dart View 21 chunks +3 lines, -39 lines 0 comments Download
M pkg/analyzer/lib/src/generated/html.dart View 17 chunks +4 lines, -34 lines 0 comments Download
M pkg/analyzer/lib/src/generated/index.dart View 32 chunks +11 lines, -61 lines 0 comments Download
M pkg/analyzer/lib/src/generated/instrumentation.dart View 4 chunks +0 lines, -8 lines 0 comments Download
M pkg/analyzer/lib/src/generated/parser.dart View 85 chunks +130 lines, -140 lines 0 comments Download
M pkg/analyzer/lib/src/generated/resolver.dart View 118 chunks +110 lines, -189 lines 0 comments Download
M pkg/analyzer/lib/src/generated/scanner.dart View 16 chunks +0 lines, -32 lines 0 comments Download
M pkg/analyzer/lib/src/generated/sdk.dart View 4 chunks +1 line, -7 lines 0 comments Download
M pkg/analyzer/lib/src/generated/sdk_io.dart View 2 chunks +0 lines, -4 lines 0 comments Download
M pkg/analyzer/lib/src/generated/source.dart View 11 chunks +0 lines, -22 lines 0 comments Download
M pkg/analyzer/lib/src/generated/source_io.dart View 5 chunks +0 lines, -10 lines 0 comments Download
M pkg/analyzer/lib/src/generated/utilities_dart.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M pkg/analyzer/lib/src/services/formatter_impl.dart View 7 chunks +9 lines, -9 lines 0 comments Download
M pkg/analyzer/lib/src/services/runtime/coverage/coverage_impl.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer/lib/src/services/runtime/coverage/models.dart View 3 chunks +3 lines, -3 lines 0 comments Download
M pkg/analyzer/pubspec.yaml View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer/test/generated/ast_test.dart View 33 chunks +473 lines, -473 lines 0 comments Download
M pkg/analyzer/test/generated/element_test.dart View 34 chunks +72 lines, -72 lines 0 comments Download
M pkg/analyzer/test/generated/parser_test.dart View 22 chunks +167 lines, -167 lines 0 comments Download
M pkg/analyzer/test/generated/resolver_test.dart View 152 chunks +277 lines, -277 lines 0 comments Download
M pkg/analyzer/test/generated/test_support.dart View 2 chunks +4 lines, -4 lines 0 comments Download
M pkg/code_transformers/lib/src/resolver_impl.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/code_transformers/pubspec.yaml View 1 chunk +1 line, -1 line 0 comments Download
M pkg/intl/lib/extract_messages.dart View 4 chunks +6 lines, -6 lines 0 comments Download
M pkg/intl/pubspec.yaml View 1 1 chunk +1 line, -1 line 2 comments Download
M sdk/lib/_internal/pub/lib/src/barback/rewrite_import_transformer.dart View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (0 generated)
scheglov
6 years, 9 months ago (2014-03-02 22:15:21 UTC) #1
Brian Wilkerson
LGTM
6 years, 9 months ago (2014-03-02 22:49:00 UTC) #2
scheglov
ping Karl, Bob, can you please review changes in your analyzer clients?
6 years, 9 months ago (2014-03-03 22:32:44 UTC) #3
Bob Nystrom
Pub change LGTM! Sorry, for some reason I didn't see this code review. :( - ...
6 years, 9 months ago (2014-03-03 23:28:57 UTC) #4
karlklose
Sorry, I did not see the CL. Which part of the CL do you want ...
6 years, 9 months ago (2014-03-04 07:58:53 UTC) #5
scheglov
On 2014/03/04 07:58:53, karlklose wrote: > Sorry, I did not see the CL. Which part ...
6 years, 9 months ago (2014-03-04 15:08:02 UTC) #6
scheglov
Committed patchset #2 manually as r33296 (presubmit successful).
6 years, 9 months ago (2014-03-04 20:02:46 UTC) #7
Alan Knight
https://codereview.chromium.org/185603002/diff/20001/pkg/intl/pubspec.yaml File pkg/intl/pubspec.yaml (right): https://codereview.chromium.org/185603002/diff/20001/pkg/intl/pubspec.yaml#newcode8 pkg/intl/pubspec.yaml:8: analyzer: "0.13.0-dev.2" I don't understand how this works to ...
6 years, 9 months ago (2014-03-04 20:30:33 UTC) #8
scheglov
6 years, 9 months ago (2014-03-04 20:35:41 UTC) #9
Message was sent while issue was closed.
https://codereview.chromium.org/185603002/diff/20001/pkg/intl/pubspec.yaml
File pkg/intl/pubspec.yaml (right):

https://codereview.chromium.org/185603002/diff/20001/pkg/intl/pubspec.yaml#ne...
pkg/intl/pubspec.yaml:8: analyzer: "0.13.0-dev.2"
On 2014/03/04 20:30:34, Alan Knight wrote:
> I don't understand how this works to have a dependency on a dev version. And
my
> understanding was that a dev version isn't published, but this version appears
> to be published to pub. Shouldn't it just be released as a normal version?

I was told in https://codereview.chromium.org/175793004/ that I can publish -dev
versions.

Powered by Google App Engine
This is Rietveld 408576698