Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(129)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1856003002: Replace FDE_XMLSYNTAX defines with enum classes. (Closed)

Created:
4 years, 8 months ago by dsinclair
Modified:
4 years, 8 months ago
Reviewers:
Tom Sepez
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Replace FDE_XMLSYNTAX defines with enum classes. This CL replaces FDE_XMLSYNTAXMODE_ with FDE_XmlSyntaxState:: and FDE_XMLSYNTAXSTATUS_ with FDE_XmlSyntaxResult::. The various variables also have their names updated to make them clearer. Committed: https://pdfium.googlesource.com/pdfium/+/6e56a5ebc88e05fe0bf05624eba9aeed57fa6d60

Patch Set 1 #

Patch Set 2 : #

Total comments: 2

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+319 lines, -313 lines) Patch
M xfa/fde/xml/fde_xml.h View 1 2 chunks +18 lines, -16 lines 0 comments Download
M xfa/fde/xml/fde_xml_imp.h View 1 2 4 chunks +26 lines, -24 lines 0 comments Download
M xfa/fde/xml/fde_xml_imp.cpp View 31 chunks +146 lines, -144 lines 0 comments Download
M xfa/fde/xml/fde_xml_imp_unittest.cpp View 12 chunks +101 lines, -101 lines 0 comments Download
M xfa/fxfa/parser/xfa_parser_imp.h View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fxfa/parser/xfa_parser_imp.cpp View 7 chunks +27 lines, -27 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
dsinclair
PTAL.
4 years, 8 months ago (2016-04-04 16:06:13 UTC) #2
Tom Sepez
lgtm https://codereview.chromium.org/1856003002/diff/20001/xfa/fde/xml/fde_xml_imp.h File xfa/fde/xml/fde_xml_imp.h (right): https://codereview.chromium.org/1856003002/diff/20001/xfa/fde/xml/fde_xml_imp.h#newcode16 xfa/fde/xml/fde_xml_imp.h:16: Text, can this be nested in the CFDE_XMLSyntaxParser ...
4 years, 8 months ago (2016-04-04 18:24:57 UTC) #3
dsinclair
https://codereview.chromium.org/1856003002/diff/20001/xfa/fde/xml/fde_xml_imp.h File xfa/fde/xml/fde_xml_imp.h (right): https://codereview.chromium.org/1856003002/diff/20001/xfa/fde/xml/fde_xml_imp.h#newcode16 xfa/fde/xml/fde_xml_imp.h:16: Text, On 2016/04/04 18:24:57, Tom Sepez wrote: > can ...
4 years, 8 months ago (2016-04-04 18:40:56 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1856003002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1856003002/40001
4 years, 8 months ago (2016-04-04 18:41:02 UTC) #7
commit-bot: I haz the power
4 years, 8 months ago (2016-04-04 18:55:42 UTC) #9
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) as
https://pdfium.googlesource.com/pdfium/+/6e56a5ebc88e05fe0bf05624eba9aeed57fa...

Powered by Google App Engine
This is Rietveld 408576698