Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(397)

Issue 1855993002: Remove 'native' context unit test macro. (Closed)

Created:
4 years, 8 months ago by bsalomon
Modified:
4 years, 8 months ago
Reviewers:
jvanverth1, egdaniel
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@fixx1
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Remove 'native' context unit test macro. The only test ran long is GLPrograms. I halved its iteration count to preserve the runtime on devices that support GL and GLES. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1855993002 Committed: https://skia.googlesource.com/skia/+/f3261afed2b2a7853a3f94a7e5b0c11683c09579

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -29 lines) Patch
M tests/GLProgramsTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M tests/ImageFilterTest.cpp View 1 11 chunks +11 lines, -11 lines 0 comments Download
M tests/ImageTest.cpp View 1 4 chunks +4 lines, -4 lines 0 comments Download
M tests/ReadPixelsTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M tests/Test.h View 1 chunk +0 lines, -2 lines 0 comments Download
M tests/TestTest.cpp View 1 chunk +0 lines, -10 lines 0 comments Download

Messages

Total messages: 13 (7 generated)
bsalomon
Part of removing the idea of a native context type. FYI, the GLPrograms test ran ...
4 years, 8 months ago (2016-04-04 14:59:53 UTC) #3
egdaniel
lgtm
4 years, 8 months ago (2016-04-04 19:12:26 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1855993002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1855993002/1
4 years, 8 months ago (2016-04-05 17:07:11 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: Build-Ubuntu-Clang-x86_64-Debug-Trybot on client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-Clang-x86_64-Debug-Trybot/builds/7610)
4 years, 8 months ago (2016-04-05 17:09:24 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1855993002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1855993002/20001
4 years, 8 months ago (2016-04-05 17:42:18 UTC) #11
commit-bot: I haz the power
4 years, 8 months ago (2016-04-05 17:57:18 UTC) #13
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/f3261afed2b2a7853a3f94a7e5b0c11683c09579

Powered by Google App Engine
This is Rietveld 408576698