Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(75)

Issue 1855973002: [Password Manager] |index| in requests to PasswordManagerPresenter might be out of bounds (Closed)

Created:
4 years, 8 months ago by kolos1
Modified:
4 years, 8 months ago
Reviewers:
vabr (Chromium)
CC:
chromium-reviews, gcasto+watchlist_chromium.org, vabr+watchlistpasswordmanager_chromium.org, mkwst+watchlist-passwords_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Password Manager] |index| in requests to PasswordManagerPresenter might be out of bounds, because of recent changes in the password store. This CL removes |NOTREACHED()| for such cases. BUG=600374 Committed: https://crrev.com/5aba8a4194a67a712de8cf784dd626e9e6809e53 Cr-Commit-Position: refs/heads/master@{#384915}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -15 lines) Patch
M chrome/browser/ui/passwords/password_manager_presenter.cc View 5 chunks +20 lines, -15 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 10 (5 generated)
kolos1
Hi Vaclav, Please review this small CL, if you have some time. Best regards, Maxim
4 years, 8 months ago (2016-04-04 14:24:57 UTC) #3
vabr (Chromium)
Thank you, Maxim, this LGTM. Cheers, Vaclav
4 years, 8 months ago (2016-04-04 14:31:26 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1855973002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1855973002/1
4 years, 8 months ago (2016-04-04 14:42:29 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-04 15:41:58 UTC) #8
commit-bot: I haz the power
4 years, 8 months ago (2016-04-04 15:43:13 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5aba8a4194a67a712de8cf784dd626e9e6809e53
Cr-Commit-Position: refs/heads/master@{#384915}

Powered by Google App Engine
This is Rietveld 408576698