Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1855943002:
[heap] Respect idle deadline in AdvanceIncrementalMarking more carefully. (Closed)
|
Created:
4 years, 8 months ago by Hannes Payer (out of office) Modified:
4 years, 8 months ago Reviewers:
ulan CC:
ulan, Hannes Payer (out of office), v8-reviews_googlegroups.com Base URL:
https://chromium.googlesource.com/v8/v8.git@master Target Ref:
refs/pending/heads/master Project:
v8 Visibility:
Public. |
Description[heap] Respect idle deadline in AdvanceIncrementalMarking more carefully.
Committed: https://crrev.com/0eb53167f492a44d26b68c2197e37452f70c3a4f
Cr-Commit-Position: refs/heads/master@{#35288}
Patch Set 1 #Patch Set 2 : #Patch Set 3 : #Patch Set 4 : #
Messages
Total messages: 23 (10 generated)
hpayer@chromium.org changed reviewers: + ulan@chromium.org
The CQ bit was checked by hpayer@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1855943002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1855943002/1
The CQ bit was unchecked by commit-bot@chromium.org
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full committers or once the patch has received an L-G-T-M from a full committer. Even if an L-G-T-M may have been provided, it was from a non-committer, _not_ a full super star committer. Committers are members of the group "project-v8-committers". Note that this has nothing to do with OWNERS files.
lgtm
The CQ bit was checked by hpayer@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1855943002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1855943002/1
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: v8_linux64_asan_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_asan_rel/builds/...) v8_linux64_avx2_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_avx2_rel/builds/...) v8_linux_arm64_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm64_rel/builds/1...) v8_linux_arm_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm_rel/builds/16161) v8_linux_dbg_ng on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_dbg_ng/builds/3753) v8_linux_gcc_compile_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_gcc_compile_rel/bu...) v8_linux_mips64el_compile_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_mips64el_compile_r...) v8_linux_mipsel_compile_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_mipsel_compile_rel...) v8_linux_nodcheck_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_nodcheck_rel/build...) v8_linux_rel_ng on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_rel_ng/builds/3752) v8_presubmit on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/13183)
The CQ bit was checked by hpayer@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from ulan@chromium.org Link to the patchset: https://codereview.chromium.org/1855943002/#ps20001 (title: " ")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1855943002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1855943002/20001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: v8_linux64_avx2_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_avx2_rel/builds/...)
PS 4 lgtm
The CQ bit was checked by hpayer@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1855943002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1855943002/60001
Message was sent while issue was closed.
Committed patchset #4 (id:60001)
Message was sent while issue was closed.
Description was changed from ========== [heap] Respect idle deadline in AdvanceIncrementalMarking more carefully. ========== to ========== [heap] Respect idle deadline in AdvanceIncrementalMarking more carefully. Committed: https://crrev.com/0eb53167f492a44d26b68c2197e37452f70c3a4f Cr-Commit-Position: refs/heads/master@{#35288} ==========
Message was sent while issue was closed.
Patchset 4 (id:??) landed as https://crrev.com/0eb53167f492a44d26b68c2197e37452f70c3a4f Cr-Commit-Position: refs/heads/master@{#35288}
Message was sent while issue was closed.
A revert of this CL (patchset #4 id:60001) has been created in https://codereview.chromium.org/1870613002/ by hablich@chromium.org. The reason for reverting is: Reverting because of https://bugs.chromium.org/p/chromium/issues/detail?id=601204. |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
