Chromium Code Reviews

Issue 1855943002: [heap] Respect idle deadline in AdvanceIncrementalMarking more carefully. (Closed)

Created:
4 years, 8 months ago by Hannes Payer (out of office)
Modified:
4 years, 8 months ago
Reviewers:
ulan
CC:
ulan, Hannes Payer (out of office), v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[heap] Respect idle deadline in AdvanceIncrementalMarking more carefully. Committed: https://crrev.com/0eb53167f492a44d26b68c2197e37452f70c3a4f Cr-Commit-Position: refs/heads/master@{#35288}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Unified diffs Side-by-side diffs Stats (+11 lines, -10 lines)
M src/heap/gc-idle-time-handler.h View 1 chunk +4 lines, -0 lines 0 comments
M src/heap/incremental-marking.cc View 1 chunk +7 lines, -10 lines 0 comments

Messages

Total messages: 23 (10 generated)
Hannes Payer (out of office)
4 years, 8 months ago (2016-04-04 12:48:36 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1855943002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1855943002/1
4 years, 8 months ago (2016-04-04 12:48:47 UTC) #4
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full ...
4 years, 8 months ago (2016-04-04 12:48:48 UTC) #6
ulan
lgtm
4 years, 8 months ago (2016-04-04 13:38:40 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1855943002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1855943002/1
4 years, 8 months ago (2016-04-04 13:55:14 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux64_asan_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_asan_rel/builds/16087) v8_linux64_avx2_rel on tryserver.v8 (JOB_FAILED, ...
4 years, 8 months ago (2016-04-04 13:56:25 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1855943002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1855943002/20001
4 years, 8 months ago (2016-04-04 16:40:01 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux64_avx2_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_avx2_rel/builds/12465)
4 years, 8 months ago (2016-04-04 16:51:51 UTC) #16
ulan
PS 4 lgtm
4 years, 8 months ago (2016-04-06 08:45:28 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1855943002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1855943002/60001
4 years, 8 months ago (2016-04-06 08:53:35 UTC) #19
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 8 months ago (2016-04-06 09:06:08 UTC) #20
commit-bot: I haz the power
Patchset 4 (id:??) landed as https://crrev.com/0eb53167f492a44d26b68c2197e37452f70c3a4f Cr-Commit-Position: refs/heads/master@{#35288}
4 years, 8 months ago (2016-04-06 09:07:44 UTC) #22
Michael Hablich
4 years, 8 months ago (2016-04-07 07:14:02 UTC) #23
Message was sent while issue was closed.
A revert of this CL (patchset #4 id:60001) has been created in
https://codereview.chromium.org/1870613002/ by hablich@chromium.org.

The reason for reverting is: Reverting because of
https://bugs.chromium.org/p/chromium/issues/detail?id=601204.

Powered by Google App Engine