Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1455)

Issue 185593011: Apply 'x-content-type-options' check to dynamically inserted script. (Closed)

Created:
6 years, 9 months ago by Mike West
Modified:
6 years, 9 months ago
Reviewers:
Tom Sepez
CC:
blink-reviews, sof, eae+blinkwatch, dglazkov+blink, adamk+blink_chromium.org, Inactive, rwlbuis
Visibility:
Public.

Description

Apply 'x-content-type-options' check to dynamically inserted script. BUG=348581 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=168570

Patch Set 1 #

Patch Set 2 : Test. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -7 lines) Patch
A + LayoutTests/http/tests/security/contentTypeOptions/nosniff-dynamic-script-blocked.html View 1 1 chunk +7 lines, -2 lines 0 comments Download
A + LayoutTests/http/tests/security/contentTypeOptions/nosniff-dynamic-script-blocked-expected.txt View 1 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/dom/ScriptLoader.cpp View 1 chunk +6 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Mike West
Hey Tom, mind taking a look at this? -mike
6 years, 9 months ago (2014-03-04 09:15:54 UTC) #1
Tom Sepez
LGTM modulo getting the test to pass.
6 years, 9 months ago (2014-03-04 17:59:35 UTC) #2
Mike West
On 2014/03/04 17:59:35, Tom Sepez wrote: > LGTM modulo getting the test to pass. Ah, ...
6 years, 9 months ago (2014-03-04 18:32:27 UTC) #3
Mike West
The CQ bit was checked by mkwst@chromium.org
6 years, 9 months ago (2014-03-05 09:40:26 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mkwst@chromium.org/185593011/20001
6 years, 9 months ago (2014-03-05 09:41:03 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mkwst@chromium.org/185593011/20001
6 years, 9 months ago (2014-03-05 20:57:46 UTC) #6
commit-bot: I haz the power
6 years, 9 months ago (2014-03-06 04:17:49 UTC) #7
Message was sent while issue was closed.
Change committed as 168570

Powered by Google App Engine
This is Rietveld 408576698