Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(66)

Issue 1855913002: [interpreter] add some expression positions. (Closed)

Created:
4 years, 8 months ago by Yang
Modified:
4 years, 8 months ago
CC:
v8-reviews_googlegroups.com, oth, rmcilroy
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[interpreter] add some expression positions. Statement positions should overwrite expression positions if they have the same bytecode offset. R=mstarzinger@chromium.org, vogelheim@chromium.org BUG=v8:4680, v8:4689 LOG=N Committed: https://crrev.com/f7e7ba11258f1820d25025420a55f08695742c85 Cr-Commit-Position: refs/heads/master@{#35236}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -23 lines) Patch
M src/interpreter/bytecode-generator.cc View 6 chunks +6 lines, -0 lines 0 comments Download
M src/interpreter/source-position-table.cc View 1 chunk +4 lines, -1 line 0 comments Download
M test/cctest/cctest.status View 2 chunks +0 lines, -7 lines 0 comments Download
M test/message/message.status View 1 chunk +0 lines, -10 lines 1 comment Download
M test/mjsunit/mjsunit.status View 2 chunks +0 lines, -5 lines 0 comments Download

Messages

Total messages: 10 (2 generated)
Yang
4 years, 8 months ago (2016-04-04 11:52:38 UTC) #1
Yang
On 2016/04/04 11:52:38, Yang wrote: This succeeds https://codereview.chromium.org/1785973003/.
4 years, 8 months ago (2016-04-04 11:52:57 UTC) #2
Michael Starzinger
LGTM.
4 years, 8 months ago (2016-04-04 12:07:52 UTC) #3
vogelheim
https://codereview.chromium.org/1855913002/diff/1/test/message/message.status File test/message/message.status (left): https://codereview.chromium.org/1855913002/diff/1/test/message/message.status#oldcode37 test/message/message.status:37: ['ignition == True', { \o/
4 years, 8 months ago (2016-04-04 12:14:59 UTC) #4
vogelheim
lgtm
4 years, 8 months ago (2016-04-04 12:15:11 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1855913002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1855913002/1
4 years, 8 months ago (2016-04-04 12:15:51 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-04 12:36:50 UTC) #8
commit-bot: I haz the power
4 years, 8 months ago (2016-04-04 12:37:54 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f7e7ba11258f1820d25025420a55f08695742c85
Cr-Commit-Position: refs/heads/master@{#35236}

Powered by Google App Engine
This is Rietveld 408576698