Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(301)

Issue 1855853004: Removed TODO as non-matching host rules are skipped earlier. (Closed)

Created:
4 years, 8 months ago by rune
Modified:
4 years, 8 months ago
Reviewers:
Timothy Loh, esprehn
CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-css, chromium-reviews, dglazkov+blink, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Removed TODO as non-matching host rules are skipped earlier. The TODO comment was about non-matching selectors like "div:host" or ":host.class". Such selectors are ignored for RuleSet when returning SelectorNeverMatches from collectFeaturesFromRuleData. R=timloh@chromium.org,esprehn@chromium.org Committed: https://crrev.com/4b30e727444e27d018dd80540db420591499adc2 Cr-Commit-Position: refs/heads/master@{#385025}

Patch Set 1 #

Patch Set 2 : Corrected ASSERT for pseudo elements #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -3 lines) Patch
M third_party/WebKit/Source/core/css/RuleSet.cpp View 1 1 chunk +1 line, -3 lines 0 comments Download

Messages

Total messages: 15 (6 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1855853004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1855853004/1
4 years, 8 months ago (2016-04-04 14:24:32 UTC) #2
rune
ptal
4 years, 8 months ago (2016-04-04 14:24:37 UTC) #3
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_blink_oilpan_rel on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_blink_oilpan_rel/builds/25723)
4 years, 8 months ago (2016-04-04 15:04:52 UTC) #5
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1855853004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1855853004/20001
4 years, 8 months ago (2016-04-04 16:17:05 UTC) #7
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 8 months ago (2016-04-04 17:43:10 UTC) #9
esprehn
lgtm
4 years, 8 months ago (2016-04-04 22:00:19 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1855853004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1855853004/20001
4 years, 8 months ago (2016-04-04 22:00:58 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 8 months ago (2016-04-04 22:09:57 UTC) #13
commit-bot: I haz the power
4 years, 8 months ago (2016-04-04 22:12:05 UTC) #15
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/4b30e727444e27d018dd80540db420591499adc2
Cr-Commit-Position: refs/heads/master@{#385025}

Powered by Google App Engine
This is Rietveld 408576698