Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(59)

Issue 185583002: Fix "defined but not used" warning in base/message_loop/message_loop.cc (Closed)

Created:
6 years, 9 months ago by Mark Seaborn
Modified:
6 years, 9 months ago
CC:
chromium-reviews, erikwright+watch_chromium.org, sadrul
Visibility:
Public.

Description

Fix "defined but not used" warning in base/message_loop/message_loop.cc PNaCl is being upgraded to Clang 3.4, which now warns about unused declarations inside anonymous namespaces. BUG=https://code.google.com/p/nativeclient/issues/detail?id=3757 TEST=compile using new PNaCl toolchain R=darin@chromium.org, thakis@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=254690

Patch Set 1 #

Patch Set 2 : Cleaner version #

Patch Set 3 : Revert to patch set 1 version #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M base/message_loop/message_loop.cc View 2 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Mark Seaborn
Putting an #if between two decls like this is obviously pretty ugly. Is there something ...
6 years, 9 months ago (2014-03-03 16:39:13 UTC) #1
Mark Seaborn
On 2014/03/03 16:39:13, Mark Seaborn wrote: > Putting an #if between two decls like this ...
6 years, 9 months ago (2014-03-03 21:39:51 UTC) #2
Nico
lgtm I like patch set 1 better fwiw.
6 years, 9 months ago (2014-03-04 02:25:59 UTC) #3
Mark Seaborn
On 2014/03/04 02:25:59, Nico wrote: > lgtm > > I like patch set 1 better ...
6 years, 9 months ago (2014-03-04 03:01:58 UTC) #4
darin (slow to review)
Hmm, sadly this file is quite the #ifdef soup. There is probably some much better ...
6 years, 9 months ago (2014-03-04 04:43:50 UTC) #5
Mark Seaborn
6 years, 9 months ago (2014-03-04 06:06:32 UTC) #6
Message was sent while issue was closed.
Committed patchset #3 manually as r254690 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698