Chromium Code Reviews Chromium Code Reviews
Issue 1855823003:
Implement Node.isConnected (Closed)
Base URL: https://chromium.googlesource.com/chromium/src.git@master| Index: third_party/WebKit/LayoutTests/shadow-dom/node-isConnected.html |
| diff --git a/third_party/WebKit/LayoutTests/shadow-dom/node-isConnected.html b/third_party/WebKit/LayoutTests/shadow-dom/node-isConnected.html |
| new file mode 100644 |
| index 0000000000000000000000000000000000000000..b9fa2d375c0a9baf79581e2431a38229d7a32c1f |
| --- /dev/null |
| +++ b/third_party/WebKit/LayoutTests/shadow-dom/node-isConnected.html |
| @@ -0,0 +1,49 @@ |
| +<!DOCTYPE html> |
| +<script src='../resources/testharness.js'></script> |
| +<script src='../resources/testharnessreport.js'></script> |
| +<div id="log"></div> |
| +<div id="host"></div> |
| +<script> |
| + |
| +var host = document.getElementById('host'); |
| +host.attachShadow({mode: 'open'}); |
| +var orphan1 = document.createElement('div'); |
|
kochi
2016/04/05 05:32:28
Now you can move these 2 lines into the test funct
yuzuchan
2016/04/05 06:48:48
Done.
|
| + |
| +test(function() { |
| + assert_false(orphan1.isConnected); |
| + host.shadowRoot.appendChild(orphan1); |
| + assert_true(orphan1.isConnected); |
| +}, 'When inserted into a connected shadow tree, isConnected should be true.'); |
| + |
| +test(function() { |
|
kochi
2016/04/05 05:32:28
Probably this test should come first, before the t
yuzuchan
2016/04/05 06:48:48
Done.
|
| + var orphan2 = document.createElement('div'); |
|
kochi
2016/04/05 05:32:28
How about adding
assert_false(orphan2.isConnected)
yuzuchan
2016/04/05 06:48:48
Done.
|
| + host.appendChild(orphan2); |
| + assert_true(orphan2.isConnected); |
| +}, 'When inserted into a document tree, isConnected should be true.'); |
| + |
| +test(function() { |
| + var orphan3 = document.createElement('div'); |
| + var host2 = document.createElement('div'); |
| + host2.attachShadow({mode: 'open'}); |
| + host2.shadowRoot.appendChild(orphan3); |
| + assert_false(host2.isConnected); |
| + assert_false(host2.shadowRoot.isConnected); |
| + assert_false(orphan3.isConnected); |
| +}, 'When inserted into a detached tree, isConnected should be false.'); |
| + |
| +test(function() { |
| + var orphan4 = document.createElement('div'); |
| + var host3 = document.createElement('div'); |
| + var host4 = document.createElement('div'); |
| + host3.attachShadow({mode: 'open'}); |
| + host4.attachShadow({mode: 'open'}); |
| + host4.shadowRoot.appendChild(orphan4); |
| + host3.shadowRoot.appendChild(host4); |
| + assert_false(host3.isConnected); |
| + assert_false(host3.shadowRoot.isConnected); |
| + assert_false(host4.isConnected); |
| + assert_false(host4.shadowRoot.isConnected); |
| + assert_false(orphan4.isConnected); |
|
kochi
2016/04/05 05:32:28
How about adding
host.appendChild(host3);
here and
yuzuchan
2016/04/05 06:48:48
Done.
|
| +}, 'When inserted into a detached shadow tree, isConnected should be false.'); |
| + |
| +</script> |
