Fix flaky test OneClickSigninBubbleViewBrowserTest::ShowBubble

chrome/browser/ui/views/sync/one_click_signin_bubble_view.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/views/sync/one_click_signin_bubble_view.h"
 
 #include "base/callback_helpers.h"
 #include "base/logging.h"
 #include "base/message_loop/message_loop.h"
 #include "chrome/browser/google/google_util.h"
 #include "chrome/browser/ui/browser.h"
 #include "chrome/browser/ui/sync/one_click_signin_helper.h"
 #include "chrome/browser/ui/sync/one_click_signin_histogram.h"
 #include "chrome/common/url_constants.h"
-#include "content/public/browser/web_contents.h"
 #include "grit/chromium_strings.h"
 #include "grit/generated_resources.h"
 #include "grit/theme_resources.h"
 #include "grit/ui_resources.h"
 #include "ui/base/keycodes/keyboard_codes.h"
 #include "ui/base/l10n/l10n_util.h"
 #include "ui/base/resource/resource_bundle.h"
 #include "ui/views/controls/button/image_button.h"
 #include "ui/views/controls/button/label_button.h"
 #include "ui/views/controls/image_view.h"
@@ skipping 20 matching lines @@
 }  // namespace
 
 // static
 OneClickSigninBubbleView* OneClickSigninBubbleView::bubble_view_ = NULL;
 
 // static
 void OneClickSigninBubbleView::ShowBubble(
     BrowserWindow::OneClickSigninBubbleType type,
     const string16& email,
     const string16& error_message,
-    ToolbarView* toolbar_view,
+    scoped_ptr<OneClickSigninBubbleDelegate> delegate,
+    views::View* anchor_view,
     const BrowserWindow::StartSyncCallback& start_sync) {
   if (IsShowing())
     return;
 
   switch (type) {
     case BrowserWindow::ONE_CLICK_SIGNIN_BUBBLE_TYPE_BUBBLE:
-      bubble_view_ = new OneClickSigninBubbleView(
-          toolbar_view->GetWebContents(), toolbar_view->app_menu(),
-          error_message, string16(), start_sync, false);
+      bubble_view_ = new OneClickSigninBubbleView(error_message,

[bcwhite, 2013/07/25 20:16:14]

I think you should stick with multiple parameters on each line, starting with
the second line indented 4 spaces.  Here and elsewhere.

+                                                  string16(),
+                                                  delegate.Pass(),
+                                                  anchor_view,
+                                                  start_sync,
+                                                  false);
       break;
     case BrowserWindow::ONE_CLICK_SIGNIN_BUBBLE_TYPE_MODAL_DIALOG:
-      bubble_view_ = new OneClickSigninBubbleView(
-          toolbar_view->GetWebContents(), toolbar_view->location_bar(),
-          string16(), string16(), start_sync, true);
+      bubble_view_ = new OneClickSigninBubbleView(string16(),
+                                                  string16(),
+                                                  delegate.Pass(),
+                                                  anchor_view,
+                                                  start_sync,
+                                                  true);
       break;
     case BrowserWindow::ONE_CLICK_SIGNIN_BUBBLE_TYPE_SAML_MODAL_DIALOG:
-      bubble_view_ = new OneClickSigninBubbleView(
-          toolbar_view->GetWebContents(), toolbar_view->location_bar(),
-          string16(), email, start_sync, true);
+      bubble_view_ = new OneClickSigninBubbleView(string16(),
+                                                  email,
+                                                  delegate.Pass(),
+                                                  anchor_view,
+                                                  start_sync,
+                                                  true);
       break;
   }
 
   views::BubbleDelegateView::CreateBubble(bubble_view_)->Show();
 }
 
 // static
 bool OneClickSigninBubbleView::IsShowing() {
   return bubble_view_ != NULL;
 }
 
 // static
 void OneClickSigninBubbleView::Hide() {
   if (IsShowing())
     bubble_view_->GetWidget()->Close();
 }
 
 OneClickSigninBubbleView::OneClickSigninBubbleView(
-    content::WebContents* web_contents,
-    views::View* anchor_view,
     const string16& error_message,
     const string16& email,
+    scoped_ptr<OneClickSigninBubbleDelegate> delegate,
+    views::View* anchor_view,
     const BrowserWindow::StartSyncCallback& start_sync_callback,
     bool is_sync_dialog)
     : BubbleDelegateView(anchor_view, views::BubbleBorder::TOP_RIGHT),
-      web_contents_(web_contents),
+      delegate_(delegate.Pass()),
       error_message_(error_message),
       email_(email),
       start_sync_callback_(start_sync_callback),
       is_sync_dialog_(is_sync_dialog),
       advanced_link_(NULL),
       learn_more_link_(NULL),
       ok_button_(NULL),
       undo_button_(NULL),
       close_button_(NULL),
       clicked_learn_more_(false),
@@ skipping 223 matching lines @@
 }
 
 void OneClickSigninBubbleView::LinkClicked(views::Link* source,
                                            int event_flags) {
   if (source == learn_more_link_) {
     if (is_sync_dialog_ && !clicked_learn_more_) {
       OneClickSigninHelper::LogConfirmHistogramValue(
           one_click_signin::HISTOGRAM_CONFIRM_LEARN_MORE);
       clicked_learn_more_ = true;
     }
-
-    WindowOpenDisposition location =
-      is_sync_dialog_ ? NEW_WINDOW : NEW_FOREGROUND_TAB;
-
-    content::OpenURLParams params(
-        GURL(chrome::kChromeSyncLearnMoreURL), content::Referrer(),
-        location, content::PAGE_TRANSITION_LINK, false);
-    web_contents_->OpenURL(params);
+    delegate_->OnLearnMoreLinkClicked(is_sync_dialog_);
 
     // don't hide the modal dialog, as this is an informational link
     if (is_sync_dialog_)
       return;
   } else if (advanced_link_ && source == advanced_link_) {
     if (is_sync_dialog_) {
       OneClickSigninHelper::LogConfirmHistogramValue(
         clicked_learn_more_ ?
             one_click_signin::HISTOGRAM_CONFIRM_LEARN_MORE_ADVANCED :
             one_click_signin::HISTOGRAM_CONFIRM_ADVANCED);
 
       base::ResetAndReturn(&start_sync_callback_).Run(
       OneClickSigninSyncStarter::CONFIGURE_SYNC_FIRST);
     } else {
-      content::OpenURLParams params(
-          GURL(chrome::kChromeUISettingsURL), content::Referrer(),
-          CURRENT_TAB, content::PAGE_TRANSITION_LINK, false);
-      web_contents_->OpenURL(params);
+      delegate_->OnAdvancedLinkClicked();
     }
   }
 
   Hide();
 }
 
 void OneClickSigninBubbleView::ButtonPressed(views::Button* sender,
                                              const ui::Event& event) {
   Hide();
 
@@ skipping 27 matching lines @@
   // we'll be destroyed asynchronously and the shown state will be checked
   // before then.
   DCHECK_EQ(bubble_view_, this);
   bubble_view_ = NULL;
 
   if (is_sync_dialog_ && !start_sync_callback_.is_null()) {
     base::ResetAndReturn(&start_sync_callback_).Run(
         OneClickSigninSyncStarter::SYNC_WITH_DEFAULT_SETTINGS);
   }
 }