third_party/WebKit/Source/wtf/Optional.h - Issue 1855763002: CL for perf tryjob on android

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/wtf/Optional.h

Issue 1855763002: CL for perf tryjob on android Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/wtf/Optional.h

diff --git a/third_party/WebKit/Source/wtf/Optional.h b/third_party/WebKit/Source/wtf/Optional.h

index 3d8ac1824b0f2ad443112d0ff9eca3ee24e10e0e..1c2e422f522d6cb210e65f7ed6f71cf3597c6be4 100644

--- a/third_party/WebKit/Source/wtf/Optional.h

+++ b/third_party/WebKit/Source/wtf/Optional.h

@@ -54,7 +54,7 @@ public:

template <typename... Args>

void emplace(Args&&... args)

{

- CHECK(!m_ptr);

+ RELEASE_ASSERT(!m_ptr);

m_ptr = reinterpret_cast_ptr<T*>(&m_storage.buffer);

new (m_ptr) T(std::forward<Args>(args)...);

}