src/effects/SkPixelXorXfermode.cpp - Issue 1855733002: change flattenable factory to return sk_sp

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/effects/SkPixelXorXfermode.cpp

Issue 1855733002: change flattenable factory to return sk_sp (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/effects/SkPixelXorXfermode.cpp

diff --git a/src/effects/SkPixelXorXfermode.cpp b/src/effects/SkPixelXorXfermode.cpp

index 4ad3f1bd766a91c13679afe5d584967cd84a238e..d8861e6df111c37fef44e67719c23cc766380a69 100644

--- a/src/effects/SkPixelXorXfermode.cpp

+++ b/src/effects/SkPixelXorXfermode.cpp

@@ -26,8 +26,8 @@ void SkPixelXorXfermode::flatten(SkWriteBuffer& wb) const {

SkGetPackedB32(fOpColor)));

}

-SkFlattenable* SkPixelXorXfermode::CreateProc(SkReadBuffer& buffer) {

- return Make(buffer.readColor()).release();

+sk_sp<SkFlattenable> SkPixelXorXfermode::CreateProc(SkReadBuffer& buffer) {

+ return Make(buffer.readColor());

}

#ifndef SK_IGNORE_TO_STRING