Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(682)

Issue 1855683002: Subzero: Fix -timing-funcs and -timing-focus flags. (Closed)

Created:
4 years, 8 months ago by Jim Stichnoth
Modified:
4 years, 8 months ago
Reviewers:
Eric Holk, Karl, sehr, John
CC:
native-client-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Subzero: Fix -timing-funcs and -timing-focus flags. 1. Generate dummy FunctionXXX function names when either of those flags is given. 2. Remove the browser code that automatically sets F/G prefixes instead of Function/Global, since that performance tweak is no longer relevant. 3. Fix a presumably long-standing bug where -timing-focus would accumulate timings into the TLS copy of the timers, but would then try to print timing info based on the currently-empty GlobalContext copy of the timers. BUG= none R=kschimpf@google.com Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a=commit;h=318c01bca3cebe3a452333a5bc4bf64b8ab817c8

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -17 lines) Patch
M src/IceCfg.cpp View 1 2 chunks +13 lines, -7 lines 0 comments Download
M src/IceClFlags.def View 1 chunk +4 lines, -6 lines 0 comments Download
M src/IceGlobalContext.h View 1 1 chunk +5 lines, -2 lines 0 comments Download
M src/IceGlobalContext.cpp View 1 2 chunks +6 lines, -1 line 0 comments Download
M src/PNaClTranslator.cpp View 1 1 chunk +8 lines, -1 line 0 comments Download

Messages

Total messages: 6 (3 generated)
Jim Stichnoth
4 years, 8 months ago (2016-04-02 17:16:08 UTC) #3
Karl
lgtm
4 years, 8 months ago (2016-04-02 17:23:32 UTC) #4
Jim Stichnoth
4 years, 8 months ago (2016-04-04 04:58:08 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
318c01bca3cebe3a452333a5bc4bf64b8ab817c8 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698