scripts/slave/recipes/chromium.expected/full_chromium_android_Android_Webview_L__dbg_.json - Issue 1855663002: Make android's run_instrumentation_suite() use generated wrapper scripts

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: scripts/slave/recipes/chromium.expected/full_chromium_android_Android_Webview_L__dbg_.json

Issue 1855663002: Make android's run_instrumentation_suite() use generated wrapper scripts (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/build.git@wrapper-1

Patch Set: Fix wrapper script return value Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« scripts/slave/recipe_modules/chromium_tests/steps.py ('K') | « scripts/slave/recipes/chromium.expected/dynamic_instrumentation_test.json ('k') | scripts/slave/recipes/chromium.expected/full_chromium_android_Android_Webview_M__dbg_.json » ('j') | scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_android32_tests__l_nexus5_.json » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: scripts/slave/recipes/chromium.expected/full_chromium_android_Android_Webview_L__dbg_.json

diff --git a/scripts/slave/recipes/chromium.expected/full_chromium_android_Android_Webview_L__dbg_.json b/scripts/slave/recipes/chromium.expected/full_chromium_android_Android_Webview_L__dbg_.json

index 65806c08525e5f82e3732f5de6d6280552708092..3b2853e84501e46df4d320c863d1d5536562011c 100644

--- a/scripts/slave/recipes/chromium.expected/full_chromium_android_Android_Webview_L__dbg_.json

+++ b/scripts/slave/recipes/chromium.expected/full_chromium_android_Android_Webview_L__dbg_.json

@@ -446,36 +446,14 @@

{

"cmd": [

- "[SLAVE_BUILD]/src/build/android/adb_install_apk.py",

- "[SLAVE_BUILD]/src/out/Debug/apks/SystemWebViewShell.apk",

- "-v",

- "--blacklist-file",

- "[SLAVE_BUILD]/src/out/bad_devices.json"

- ],

- "cwd": "[SLAVE_BUILD]",

- "env": {

- "PATH": "[SLAVE_BUILD]/src/third_party/android_tools/sdk/platform-tools:[SLAVE_BUILD]/src/build/android:%(PATH)s"

- },

- "name": "install SystemWebViewShell.apk"

- },

- {

- "cmd": [

"python",

"-u",

- "[SLAVE_BUILD]/src/build/android/test_runner.py",

+ "[SLAVE_BUILD]/src/out/Debug/bin/run_system_webview_shell_layout_test_apk",

"instrumentation",

- "--test-apk",

- "[SLAVE_BUILD]/src/out/Debug/apks/SystemWebViewShellLayoutTest.apk",

"--blacklist-file",

"[SLAVE_BUILD]/src/out/bad_devices.json",

"--logcat-output-file",

"/path/to/tmp/",

- "--apk-under-test",

- "[SLAVE_BUILD]/src/out/Debug/apks/SystemWebViewShell.apk",

- "--additional-apk",

- "[SLAVE_BUILD]/src/out/Debug/apks/SystemWebView.apk",

- "--isolate-file-path",

- "android_webview/system_webview_shell_test_apk.isolate",

"--flakiness-dashboard-server",

"test-results.appspot.com",

"--verbose",

@@ -483,7 +461,7 @@

"/path/to/tmp/json"

"cwd": "[SLAVE_BUILD]",

- "name": "Instrumentation test SystemWebViewShellLayoutTest",

+ "name": "Instrumentation test system_webview_shell_layout_test_apk",

"~followup_annotations": [

"@@@STEP_TEXT@<br/>failures:<br/>TestB<br/>@@@"

]