scripts/slave/recipes/chromium.expected/amp_split_recipe_instrumentation_trigger_failure.json - Issue 1855663002: Make android's run_instrumentation_suite() use generated wrapper scripts

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: scripts/slave/recipes/chromium.expected/amp_split_recipe_instrumentation_trigger_failure.json

Issue 1855663002: Make android's run_instrumentation_suite() use generated wrapper scripts (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/build.git@wrapper-1

Patch Set: address comments Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« scripts/slave/recipe_modules/cronet/api.py ('K') | « scripts/slave/recipes/chromium.expected/amp_split_recipe_collect_failure.json ('k') | scripts/slave/recipes/chromium.expected/amp_split_recipe_trigger_failure.json » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: scripts/slave/recipes/chromium.expected/amp_split_recipe_instrumentation_trigger_failure.json

diff --git a/scripts/slave/recipes/chromium.expected/amp_split_recipe_instrumentation_trigger_failure.json b/scripts/slave/recipes/chromium.expected/amp_split_recipe_instrumentation_trigger_failure.json

index 88d753781d88d8cadf4e0576389982727a5889e0..32539f522513ee76a77e74caa3f19fe612ae9445 100644

--- a/scripts/slave/recipes/chromium.expected/amp_split_recipe_instrumentation_trigger_failure.json

+++ b/scripts/slave/recipes/chromium.expected/amp_split_recipe_instrumentation_trigger_failure.json

@@ -559,44 +559,22 @@

{

"cmd": [

- "[SLAVE_BUILD]/src/build/android/adb_install_apk.py",

- "[SLAVE_BUILD]/src/out/Release/apks/AndroidWebView",

- "-v",

- "--blacklist-file",

- "[SLAVE_BUILD]/src/out/bad_devices.json",

- "--release"

- ],

- "cwd": "[SLAVE_BUILD]",

- "env": {

- "PATH": "[SLAVE_BUILD]/src/third_party/android_tools/sdk/platform-tools:[SLAVE_BUILD]/src/build/android:%(PATH)s"

- },

- "name": "install AndroidWebView"

- },

- {

- "cmd": [

"python",

"-u",

- "[SLAVE_BUILD]/src/build/android/test_runner.py",

+ "out/Release/bin/run_android_webview_test_apk",

"instrumentation",

- "--test-apk",

- "[SLAVE_BUILD]/src/out/Release/apks/AndroidWebViewTest",

"--blacklist-file",

"[SLAVE_BUILD]/src/out/bad_devices.json",

"--logcat-output-file",

"/path/to/tmp/",

- "--apk-under-test",

- "[SLAVE_BUILD]/src/out/Release/apks/AndroidWebView",

- "--isolate-file-path",

- "[SLAVE_BUILD]/src/android_webview/android_webview_test_apk.isolate",

"--flakiness-dashboard-server",

"test-results.appspot.com",

"--verbose",

- "--release",

"--json-results-file",

"/path/to/tmp/json"

"cwd": "[SLAVE_BUILD]",

- "name": "Instrumentation test AndroidWebViewTest",

+ "name": "Instrumentation test android_webview_test_apk",

"~followup_annotations": [

"@@@STEP_TEXT@<br/>failures:<br/>TestB<br/>@@@"

]