Revert of android: Make dex_action.gypi not call md5sum.

Revert of android: Make dex_action.gypi not call md5sum. (https://codereview.chromium.org/183883024/)

Reason for revert:
Experimentally reverting because it is possible that this CL broke the android build http://build.chromium.org/p/chromium/builders/Android/builds/21418/steps/compile/logs/stdio

Will undo the revert if this CL is innocent

Original issue's description:
> android: Make dex_action.gypi not call md5sum.
> 
> No intended behavior change.
> 
> dex_action.gypi didn't pass its input_paths variable to dex.py,
> but that was only set in a single place, and only to a single file there.
> It was only used in java_apk.gypi which does manual threading of
> stamp files to order actions (since it's a gypi, it can't easily use type
> none targets with dependencies). Since dex.py doesn't look at this
> stamp file at all, the it doesn't need to rerun when the stamp file disappears.
> 
> To make this a bit more obvious, remove dex_action.gypi's input_paths
> variable and set 'inputs' directly in the one place with the stamp file.
> (dex.py will still rerun if the name of the stamp file changes, due to
> regular timestamp handling.)
> 
> BUG=177552
> NOTRY=true
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=255325

TBR=cjhopman@chromium.org,thakis@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=177552
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=255356

[pkotwicz, 2014-03-06 15:52:39]

Created Revert of android: Make dex_action.gypi not call md5sum.

[commit-bot: I haz the power, 2014-03-06 15:53:39]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/pkotwicz@chromium.org/185563012/1

[commit-bot: I haz the power, 2014-03-06 15:53:57]

Change committed as 255356

[Nico, 2014-03-06 16:37:25]

Huh, looks like this helped:
http://build.chromium.org/p/chromium/builders/Android/builds/21419

I wonder why I and trybots didn't see this. I'll investigate. Thanks for
the revert!


On Thu, Mar 6, 2014 at 7:52 AM, <pkotwicz@chromium.org> wrote:

> Reviewers: cjhopman, Nico,
>
> Message:
> Created Revert of android: Make dex_action.gypi not call md5sum.
>
> Description:
> Revert of android: Make dex_action.gypi not call md5sum.
> (https://codereview.chromium.org/183883024/)
>
> Reason for revert:
> Experimentally reverting because it is possible that this CL broke the
> android
> build
> http://build.chromium.org/p/chromium/builders/Android/
> builds/21418/steps/compile/logs/stdio
>
> Will undo the revert if this CL is innocent
>
> Original issue's description:
>
>> android: Make dex_action.gypi not call md5sum.
>>
>
>  No intended behavior change.
>>
>
>  dex_action.gypi didn't pass its input_paths variable to dex.py,
>> but that was only set in a single place, and only to a single file there.
>> It was only used in java_apk.gypi which does manual threading of
>> stamp files to order actions (since it's a gypi, it can't easily use type
>> none targets with dependencies). Since dex.py doesn't look at this
>> stamp file at all, the it doesn't need to rerun when the stamp file
>>
> disappears.
>
>  To make this a bit more obvious, remove dex_action.gypi's input_paths
>> variable and set 'inputs' directly in the one place with the stamp file.
>> (dex.py will still rerun if the name of the stamp file changes, due to
>> regular timestamp handling.)
>>
>
>  BUG=177552
>> NOTRY=true
>>
>
>  Committed: https://src.chromium.org/viewvc/chrome?view=rev&
>> revision=255325
>>
>
> TBR=cjhopman@chromium.org,thakis@chromium.org
> NOTREECHECKS=true
> NOTRY=true
> BUG=177552
>
> Please review this at https://codereview.chromium.org/185563012/
>
> SVN Base: svn://svn.chromium.org/chrome/trunk/src
>
> Affected files (+11, -1 lines):
>   M build/android/dex_action.gypi
>   M build/android/gyp/dex.py
>   M build/java_apk.gypi
>
>
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[Nico, 2014-03-06 16:41:16]

On Thu, Mar 6, 2014 at 8:37 AM, Nico Weber <thakis@chromium.org> wrote:

> Huh, looks like this helped:
> http://build.chromium.org/p/chromium/builders/Android/builds/21419
>
> I wonder why I and trybots didn't see this. I'll investigate.
>

Oh, probably because neither did a clobber (but the Android builder does),
and I probably didn't do the dependencies change right.


> Thanks for the revert!
>
>
> On Thu, Mar 6, 2014 at 7:52 AM, <pkotwicz@chromium.org> wrote:
>
>> Reviewers: cjhopman, Nico,
>>
>> Message:
>> Created Revert of android: Make dex_action.gypi not call md5sum.
>>
>> Description:
>> Revert of android: Make dex_action.gypi not call md5sum.
>> (https://codereview.chromium.org/183883024/)
>>
>> Reason for revert:
>> Experimentally reverting because it is possible that this CL broke the
>> android
>> build
>> http://build.chromium.org/p/chromium/builders/Android/
>> builds/21418/steps/compile/logs/stdio
>>
>> Will undo the revert if this CL is innocent
>>
>> Original issue's description:
>>
>>> android: Make dex_action.gypi not call md5sum.
>>>
>>
>>  No intended behavior change.
>>>
>>
>>  dex_action.gypi didn't pass its input_paths variable to dex.py,
>>> but that was only set in a single place, and only to a single file there.
>>> It was only used in java_apk.gypi which does manual threading of
>>> stamp files to order actions (since it's a gypi, it can't easily use type
>>> none targets with dependencies). Since dex.py doesn't look at this
>>> stamp file at all, the it doesn't need to rerun when the stamp file
>>>
>> disappears.
>>
>>  To make this a bit more obvious, remove dex_action.gypi's input_paths
>>> variable and set 'inputs' directly in the one place with the stamp file.
>>> (dex.py will still rerun if the name of the stamp file changes, due to
>>> regular timestamp handling.)
>>>
>>
>>  BUG=177552
>>> NOTRY=true
>>>
>>
>>  Committed: https://src.chromium.org/viewvc/chrome?view=rev&
>>> revision=255325
>>>
>>
>> TBR=cjhopman@chromium.org,thakis@chromium.org
>> NOTREECHECKS=true
>> NOTRY=true
>> BUG=177552
>>
>> Please review this at https://codereview.chromium.org/185563012/
>>
>> SVN Base: svn://svn.chromium.org/chrome/trunk/src
>>
>> Affected files (+11, -1 lines):
>>   M build/android/dex_action.gypi
>>   M build/android/gyp/dex.py
>>   M build/java_apk.gypi
>>
>>
>>
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.