chrome/browser/sync_file_system/remote_file_sync_service.h - Issue 185563011: [SyncFS] Change RemoteFileSyncService interface to accept per-app conflict resolution policy

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/sync_file_system/remote_file_sync_service.h

Issue 185563011: [SyncFS] Change RemoteFileSyncService interface to accept per-app conflict resolution policy (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/sync_file_system/mock_remote_file_sync_service.cc ('k') | chrome/browser/sync_file_system/sync_file_system_service.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/sync_file_system/remote_file_sync_service.h

diff --git a/chrome/browser/sync_file_system/remote_file_sync_service.h b/chrome/browser/sync_file_system/remote_file_sync_service.h

index 18b1f3cecd3ea9f1e081f6eacce9b007ecdc900a..22cec45bc8e23c1d5df9057740035a2a9dbfbae2 100644

--- a/chrome/browser/sync_file_system/remote_file_sync_service.h

+++ b/chrome/browser/sync_file_system/remote_file_sync_service.h

@@ -206,11 +206,17 @@ class RemoteFileSyncService {

// Sets the conflict resolution policy. Returns SYNC_STATUS_OK on success,

// or returns an error code if the given policy is not supported or had

// an error.

+ virtual SyncStatusCode SetDefaultConflictResolutionPolicy(

+ ConflictResolutionPolicy policy) = 0;

virtual SyncStatusCode SetConflictResolutionPolicy(

+ const GURL& origin,

ConflictResolutionPolicy policy) = 0;

// Gets the conflict resolution policy.

- virtual ConflictResolutionPolicy GetConflictResolutionPolicy() const = 0;

+ virtual ConflictResolutionPolicy GetDefaultConflictResolutionPolicy()

+ const = 0;

+ virtual ConflictResolutionPolicy GetConflictResolutionPolicy(

+ const GURL& origin) const = 0;

// Returns a list of remote versions with their metadata.

// This method is typically called for a file which is in conflicting state.