Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(752)

Issue 185563010: Adding a test for SelectFileDialog. (Closed)

Created:
6 years, 9 months ago by aurimas (slooooooooow)
Modified:
6 years, 9 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Adding a test for SelectFileDialog. BUG=None NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=255705

Patch Set 1 #

Total comments: 6

Patch Set 2 : dtrainor's nits #

Patch Set 3 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+153 lines, -6 lines) Patch
A chrome/android/javatests/src/org/chromium/chrome/browser/input/SelectFileDialogTest.java View 1 1 chunk +128 lines, -0 lines 0 comments Download
M chrome/android/shell/java/src/org/chromium/chrome/shell/ChromeShellActivity.java View 1 2 4 chunks +24 lines, -3 lines 0 comments Download
M ui/android/java/src/org/chromium/ui/base/SelectFileDialog.java View 1 chunk +1 line, -3 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
aurimas (slooooooooow)
dtrainor: please take a look at this change. Aurimas
6 years, 9 months ago (2014-03-05 23:53:50 UTC) #1
David Trainor- moved to gerrit
lgtm awesome! thanks for adding this. just some small nits. https://codereview.chromium.org/185563010/diff/1/chrome/android/javatests/src/org/chromium/chrome/browser/input/SelectFileDialogTest.java File chrome/android/javatests/src/org/chromium/chrome/browser/input/SelectFileDialogTest.java (right): https://codereview.chromium.org/185563010/diff/1/chrome/android/javatests/src/org/chromium/chrome/browser/input/SelectFileDialogTest.java#newcode44 ...
6 years, 9 months ago (2014-03-06 02:00:01 UTC) #2
aurimas (slooooooooow)
https://codereview.chromium.org/185563010/diff/1/chrome/android/javatests/src/org/chromium/chrome/browser/input/SelectFileDialogTest.java File chrome/android/javatests/src/org/chromium/chrome/browser/input/SelectFileDialogTest.java (right): https://codereview.chromium.org/185563010/diff/1/chrome/android/javatests/src/org/chromium/chrome/browser/input/SelectFileDialogTest.java#newcode44 chrome/android/javatests/src/org/chromium/chrome/browser/input/SelectFileDialogTest.java:44: public Intent lastIntent; On 2014/03/06 02:00:02, David Trainor wrote: ...
6 years, 9 months ago (2014-03-06 02:09:47 UTC) #3
aurimas (slooooooooow)
newt@chromium.org: Please review changes in ui/android/*
6 years, 9 months ago (2014-03-06 02:13:06 UTC) #4
newt (away)
ui lgtm
6 years, 9 months ago (2014-03-06 04:57:43 UTC) #5
aurimas (slooooooooow)
The CQ bit was checked by aurimas@chromium.org
6 years, 9 months ago (2014-03-07 16:50:16 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/aurimas@chromium.org/185563010/40001
6 years, 9 months ago (2014-03-07 16:50:35 UTC) #7
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-07 18:23:06 UTC) #8
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) telemetry_unittests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=277484
6 years, 9 months ago (2014-03-07 18:23:06 UTC) #9
aurimas (slooooooooow)
The CQ bit was checked by aurimas@chromium.org
6 years, 9 months ago (2014-03-07 21:59:06 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/aurimas@chromium.org/185563010/40001
6 years, 9 months ago (2014-03-07 22:03:10 UTC) #11
commit-bot: I haz the power
6 years, 9 months ago (2014-03-07 22:10:13 UTC) #12
Message was sent while issue was closed.
Change committed as 255705

Powered by Google App Engine
This is Rietveld 408576698