src/parser.cc - Issue 185563004: Fix a few nits found by PVS Studio

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/parser.cc

Issue 185563004: Fix a few nits found by PVS Studio (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: rebased Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/parser.cc

diff --git a/src/parser.cc b/src/parser.cc

index ab9d6b7e5b00b75c452454b6d35ac28a7ccc04fe..c5bf0d977708df914299099f36f197a0e5b55eca 100644

--- a/src/parser.cc

+++ b/src/parser.cc

@@ -3203,7 +3203,7 @@ Statement* Parser::ParseForStatement(ZoneList<const AstRawString*>* labels,

Scanner::Location lhs_location = scanner()->peek_location();

Expression* expression = ParseExpression(false, CHECK_OK);

ForEachStatement::VisitMode mode;

- bool accept_OF = expression->AsVariableProxy();

+ bool accept_OF = expression->IsVariableProxy();

if (CheckInOrOf(accept_OF, &mode)) {

expression = this->CheckAndRewriteReferenceExpression(

« no previous file with comments | « src/objects.cc ('k') | test/cctest/test-api.cc » ('j') | no next file with comments »