Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(97)

Issue 185563004: Fix a few nits found by PVS Studio (Closed)

Created:
6 years, 9 months ago by Jakob Kummerow
Modified:
6 years, 1 month ago
CC:
v8-dev
Visibility:
Public.

Description

Fix a few nits found by PVS Studio BUG=v8:3192 LOG=n R=dslomov@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=25086

Patch Set 1 #

Patch Set 2 : rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -16 lines) Patch
M src/deoptimizer.cc View 1 1 chunk +1 line, -2 lines 0 comments Download
M src/hydrogen.cc View 1 1 chunk +4 lines, -3 lines 0 comments Download
M src/objects.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M src/parser.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/test-api.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/test-strings.cc View 1 1 chunk +5 lines, -8 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Jakob Kummerow
6 years, 1 month ago (2014-11-03 18:02:27 UTC) #2
Dmitry Lomov (no reviews)
lgtm
6 years, 1 month ago (2014-11-03 19:02:58 UTC) #3
Jakob Kummerow
6 years, 1 month ago (2014-11-03 19:45:00 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as 25086 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698