Implement quota estimation API from Storage spec

Implement quota estimation API from Storage spec

https://storage.spec.whatwg.org/#api

Adds navigator.storage.estimate() which returns a Promise
with {usage, quota} values in bytes. This is behind
the --enable-experimental-web-platform-features flag.

I2I: https://groups.google.com/a/chromium.org/d/msg/blink-dev/P6eY26vB91c/Ri4ohXOPBQAJ

R=kinuko@chromium.org

Committed: https://crrev.com/703806a09a9c9dc295e29c86d079dfef4dc67f40
Cr-Commit-Position: refs/heads/master@{#388577}

[jsbell, 2016-04-19 21:50:33]

kinuko@ - please take a look?

[jsbell, 2016-04-19 21:52:19]

Description was changed from

==========
Implement quota API from Storage spec

https://storage.spec.whatwg.org/#api

R=kinuko@chromium.org
==========

to

==========
Implement quota estimation API from Storage spec

https://storage.spec.whatwg.org/#api

Adds navigator.storage.estimate() which returns a Promise
with {usage, quota} values in bytes. This is behind
the --enable-experimental-web-platform-features flag.

I2I:
https://groups.google.com/a/chromium.org/d/msg/blink-dev/P6eY26vB91c/Ri4ohXOP...

R=kinuko@chromium.org
==========

[kinuko, 2016-04-20 05:56:33]

lgtm

https://codereview.chromium.org/1855623002/diff/20001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/storage/quota/storagemanager-estimate.html
(right):

https://codereview.chromium.org/1855623002/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/storage/quota/storagemanager-estimate.html:73:
'increase should be at least as large as value stored');
This may not always hold depending on implementation detail...? maybe add a
lightweight comment about that?

https://codereview.chromium.org/1855623002/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/storage/quota/storagemanager-estimate.html:74:
});
not sure how other idb/storage tests are doing today, but in general it might be
better to cleanup after (or before) the test?

https://codereview.chromium.org/1855623002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/modules/quota/StorageManager.cpp (right):

https://codereview.chromium.org/1855623002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/modules/quota/StorageManager.cpp:89:
m_resolver->resolve(estimate);
So we're basically just going to expose these raw values to start with, while we
may make it somewhat opaque later for security concerns... right? (Which sounds
ok to me)

https://codereview.chromium.org/1855623002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/modules/quota/StorageManager.cpp:94: // TODO:
DOMException!
TODO(jsbell) ..?

[jsbell, 2016-04-20 19:38:04]

https://codereview.chromium.org/1855623002/diff/20001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/storage/quota/storagemanager-estimate.html
(right):

https://codereview.chromium.org/1855623002/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/storage/quota/storagemanager-estimate.html:73:
'increase should be at least as large as value stored');
On 2016/04/20 05:56:32, kinuko wrote:
> This may not always hold depending on implementation detail...? maybe add a
> lightweight comment about that?

Done.

https://codereview.chromium.org/1855623002/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/storage/quota/storagemanager-estimate.html:74:
});
On 2016/04/20 05:56:32, kinuko wrote:
> not sure how other idb/storage tests are doing today, but in general it might
be
> better to cleanup after (or before) the test?

I do delete the database before (deleteDB above) but will do so after as well.

https://codereview.chromium.org/1855623002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/modules/quota/StorageManager.cpp (right):

https://codereview.chromium.org/1855623002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/modules/quota/StorageManager.cpp:89:
m_resolver->resolve(estimate);
On 2016/04/20 05:56:32, kinuko wrote:
> So we're basically just going to expose these raw values to start with, while
we
> may make it somewhat opaque later for security concerns... right? (Which
sounds
> ok to me)

Correct.

https://codereview.chromium.org/1855623002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/modules/quota/StorageManager.cpp:94: // TODO:
DOMException!
On 2016/04/20 05:56:32, kinuko wrote:
> TODO(jsbell) ..?

Convered this (and below) to use DOMException. Not sure why I didn't do it
immediately. 

(WebStorageQuotaErrors are compile-time asserted to match ExceptionCodes, which
DOMException also takes.)

[jsbell, 2016-04-20 20:56:30]

The CQ bit was checked by jsbell@chromium.org

[jsbell, 2016-04-20 20:56:30]

The patchset sent to the CQ was uploaded after l-g-t-m from kinuko@chromium.org
Link to the patchset: https://codereview.chromium.org/1855623002/#ps40001
(title: "Review feedback")

[commit-bot: I haz the power, 2016-04-20 20:56:52]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1855623002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1855623002/40001

[commit-bot: I haz the power, 2016-04-20 21:06:02]

Description was changed from

==========
Implement quota estimation API from Storage spec

https://storage.spec.whatwg.org/#api

Adds navigator.storage.estimate() which returns a Promise
with {usage, quota} values in bytes. This is behind
the --enable-experimental-web-platform-features flag.

I2I:
https://groups.google.com/a/chromium.org/d/msg/blink-dev/P6eY26vB91c/Ri4ohXOP...

R=kinuko@chromium.org
==========

to

==========
Implement quota estimation API from Storage spec

https://storage.spec.whatwg.org/#api

Adds navigator.storage.estimate() which returns a Promise
with {usage, quota} values in bytes. This is behind
the --enable-experimental-web-platform-features flag.

I2I:
https://groups.google.com/a/chromium.org/d/msg/blink-dev/P6eY26vB91c/Ri4ohXOP...

R=kinuko@chromium.org
==========

[commit-bot: I haz the power, 2016-04-20 21:06:04]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-04-22 19:26:30]

Description was changed from

==========
Implement quota estimation API from Storage spec

https://storage.spec.whatwg.org/#api

Adds navigator.storage.estimate() which returns a Promise
with {usage, quota} values in bytes. This is behind
the --enable-experimental-web-platform-features flag.

I2I:
https://groups.google.com/a/chromium.org/d/msg/blink-dev/P6eY26vB91c/Ri4ohXOP...

R=kinuko@chromium.org
==========

to

==========
Implement quota estimation API from Storage spec

https://storage.spec.whatwg.org/#api

Adds navigator.storage.estimate() which returns a Promise
with {usage, quota} values in bytes. This is behind
the --enable-experimental-web-platform-features flag.

I2I:
https://groups.google.com/a/chromium.org/d/msg/blink-dev/P6eY26vB91c/Ri4ohXOP...

R=kinuko@chromium.org

Committed: https://crrev.com/703806a09a9c9dc295e29c86d079dfef4dc67f40
Cr-Commit-Position: refs/heads/master@{#388577}
==========

[commit-bot: I haz the power, 2016-04-22 19:26:31]

Patchset 3 (id:??) landed as
https://crrev.com/703806a09a9c9dc295e29c86d079dfef4dc67f40
Cr-Commit-Position: refs/heads/master@{#388577}